Added "Receive From Socar" generator (ext) node #3281

aachman98 · 2020-05-25T15:10:57Z

Addressed problem description

Addition of a generator node to receive data input from node output. This is a dedicated node which presents a one-sided connection between Sverchok & Sorcar where mesh data is transferred from the latter.

Node Name: Receive From Sorcar
Node Category: Generators -> Generators Extended
Class Name: SvReceiveFromSorcarNode

Solution description

Usage

The node comes with 6 outputs: Vertices, Edges, Faces, VerticesMask, EdgesMask, FacesMask
Each of the socket corresponds to the components of the mesh data being stored in the node properties (namely "verts", "edges", "faces") and the their selection mask.

Default

By default, a simple Sorcar logo mesh is contained. The node behaves as a single-mesh-output node unless paired with node in the Sorcar nodetree.

Referenced

This node can be referenced inside Sorcar, and the mesh data of the object (passed as input) is transferred to this node. The node properties hold the data (unless modified externally) allowing users to remove/modify Sorcar nodetree or the object in the scene without losing the geometry.

Parameter updates

This node will update in the same way as expected from all the other Sverchok nodes. Since the mesh data and component masks are stored internally, re-evaluating Sorcar nodetree is not necessary.
In case of any update of parameters in Sorcar, the new mesh will be set in the properties once when the node gets executed, and will act as the new starting point. No further evaluations are required.

In the following examples, I first modify the Sverchok nodetree (added "Unsubdivide" node) and then modify a Sorcar node parameter ("Offset" in Poke node) to demonstrate the seamless non-destructive workflow.

Video demo: https://www.youtube.com/watch?v=pTIiMj5GpyI

Preflight checklist

Code changes complete.
Code documentation complete.
Documentation for users complete (or not required, if user never sees these changes).
Manual testing done.
Unit-tests implemented.
Ready for merge.

nodes/generators_extended/receive_from_sorcar.py

zeffii

nothing to add, it's a straightforward node.

aachman98 · 2020-05-25T17:35:04Z

I was a bit skeptical about the default mesh data (takes over 500 lines of code). If required, I'll revert back to a simple cube data (8 v, 12 e, 6 f)

zeffii · 2020-05-25T17:40:52Z

we can provide a geometry module in sverchok.utils.modules.sorcar_default_geometry don't worry about it.

nortikin · 2020-05-25T23:43:26Z

COOL!

Durman · 2020-05-26T05:00:54Z

I expect that when a new mesh will be set to the node properties Sverchok node tree will be evaluated three times in a row. What is not very cool.

aachman98 · 2020-05-26T07:01:35Z

I’ll remove the “update” for verts and edges property. The props are set in this very order, so the update will be called one time only, AFTER the data has been set.

zeffii · 2020-05-26T07:25:54Z

there's a lot of ways to implement this kind of node, usually only a steady stream of users will show us what they really need

Durman · 2020-05-26T07:32:36Z

I would suggest to remove update function from all properties and add a method to the node, like this:

def set_mesh(self, verts, edges, faces):
    self.verts = verts,
    self.edges = edges
    self.faces = faces
    updateNode(self, None)

It will make setting mesh process more clear.

aachman98 · 2020-05-26T07:37:04Z

Nice and clean! Working on it..

zeffii · 2020-05-28T10:14:00Z

here's that logo compressed into 2D.

import sverchok
from sverchok.nodes.modifier_make.solidify import solidify

def make_sorcar_logo():
    """ makes sorcar 3d - literal data"""
    a = 0.4233
    b = 0.7778
    c = 0.6878
    d = 0.3333
    e = 1.0
    f = 0.9100
    g = 0.8678
    h = 0.2433
    i = 0.6456
    j = 0.5556
    k = 0.4656
    l = 0.2011
    m = 0.1111
    n = 0.0211

    verts_2d = [
        (-a, -b), (-c, -b), (-b, -c), (-b, -d), (-e, -d), (-e, -f), (-f, -e), (-d, -e),
        (-d, -g), (-h, -b), (+h, -b), (+d, -g), (+d, -e), (+f, -e), (+e, -f), (+e, -d),
        (+b, -d), (+b, -c), (+c, -b), (+a, -b), (+d, -c), (+d, -i), (+a, -j), (+k, -j),
        (+j, -k), (+j, -l), (+k, -m), (+a, -m), (+d, -n), (+d, +n), (+h, +m), (-h, +m),
        (-d, +l), (-d, +k), (-h, +j), (+h, +j), (+d, +k), (+d, +a), (+a, +d), (+k, +d),
        (+j, +a), (+j, +k), (+k, +j), (+a, +j), (+d, +i), (+d, +c), (+a, +b), (+c, +b),
        (+b, +c), (+b, +d), (+e, +d), (+e, +f), (+f, +e), (+d, +e), (+d, +g), (+h, +b),
        (-h, +b), (-d, +g), (-d, +e), (-f, +e), (-e, +f), (-e, +d), (-b, +d), (-b, +c),
        (-c, +b), (-a, +b), (-d, +c), (-d, +i), (-a, +j), (-k, +j), (-j, +k), (-j, +l),
        (-k, +m), (-a, +m), (-d, +n), (-d, -n), (-h, -m), (+h, -m), (+d, -l), (+d, -k),
        (+h, -j), (-h, -j), (-d, -k), (-d, -a), (-a, -d), (-k, -d), (-j, -a), (-j, -k),
        (-k, -j), (-a, -j), (-d, -i), (-d, -c)
    ]

    verts_3d = [(v[0], v[1], 0.05) for v in verts_2d]
    face = list(range(len(verts_3d)))
    verts, edges, faces, _ = solidify(verts_3d, [face], [0.1])
    return verts, edges, faces

nortikin · 2020-06-07T21:29:35Z

can we merge?

aachman98 · 2020-06-07T21:36:40Z

I haven’t updated the code yet. Will push the new method with compressed mesh by tomorrow. Also, I was thinking of adding 3 new component mask outputs so that we can retain the selection.

aachman98 · 2020-06-08T15:37:10Z

zeffii · 2020-06-08T19:32:45Z

nodes/generators_extended/receive_from_sorcar.py

+from sverchok.utils.modules.geom_sorcar import make_sorcar_logo
+
+class SvReceiveFromSorcarNode(bpy.types.Node, SverchCustomTreeNode):
+    ''' Receive Mesh Data From Sorcar '''


we have a useful scheme for this , and it makes tooltips for our menus automatically

""" Triggers: sorcar sc receive Tooltip: Receive Mesh Data From Sorcar A short description for reader of node code <---not mandatory, but you could include links of interest. """

Thanks!
I don't have any links of interest (maybe except for this PR as it has some info on the top), so I'll create a separate small description and add some comments in the code.

zeffii · 2020-06-08T19:34:05Z

nodes/generators_extended/receive_from_sorcar.py

+
+    verts: StringProperty(name='Vertices',
+                         default=repr([sc_v]),
+                         options={'ANIMATABLE'})


animatable is redundant. this is the default state of properties.

I copied the code from generators -> sphere.py when I started, so I thought this was the standard way Sverchok node properties were made. It also has a one-line description.

yep, but it's not so useful to restate the default. i'm not going to retrospectively remove them, but whenever a node gets added or updated i try to nip that in the bud.

zeffii · 2020-06-08T19:35:21Z

nodes/generators_extended/receive_from_sorcar.py

+
+
+def unregister():
+    bpy.utils.unregister_class(SvReceiveFromSorcarNode)


add a new empty line

zeffii · 2020-06-08T19:35:36Z

utils/modules/geom_sorcar.py

+    verts_3d = [(v[0], v[1], 0.05) for v in verts_2d]
+    face = list(range(len(verts_3d)))
+    verts, edges, faces, _ = solidify(verts_3d, [face], [0.1])
+    return verts, edges, faces


add a new empty line

other than these things, it seems OK. i'm sure our adventurous users will be happy to have this kind of convenience. glad we can collaborate in this way.

Thank you for all the effort!

zeffii · 2020-06-08T19:37:10Z

utils/modules/geom_sorcar.py

+    verts_3d = [(v[0], v[1], 0.05) for v in verts_2d]
+    face = list(range(len(verts_3d)))
+    verts, edges, faces, _ = solidify(verts_3d, [face], [0.1])
+    return verts, edges, faces


other than these things, it seems OK. i'm sure our adventurous users will be happy to have this kind of convenience. glad we can collaborate in this way.

zeffii

at this point it's more useful to have users ride the node than suggesting code changes.

enzyme69 · 2020-06-09T21:55:27Z

Missing "Send to Sorcar" node in SV

And also getting error when sending to SV from SC.

Error: Traceback (most recent call last):
  File "/Users/jimmygunawan/Library/Application Support/Blender/2.83/scripts/addons/Sorcar-master/operators/ScExecuteNode.py", line 19, in execute
    curr_tree.execute_node()
  File "/Users/jimmygunawan/Library/Application Support/Blender/2.83/scripts/addons/Sorcar-master/tree/ScNodeTree.py", line 58, in execute_node
    if (not n.execute()):
  File "/Users/jimmygunawan/Library/Application Support/Blender/2.83/scripts/addons/Sorcar-master/nodes/_base/node_base.py", line 56, in execute
    self.functionality()
  File "/Users/jimmygunawan/Library/Application Support/Blender/2.83/scripts/addons/Sorcar-master/nodes/utilities/ScSendToSverchok.py", line 46, in functionality
    self.prop_tree.nodes[self.prop_node].set_mesh(repr(v), repr(e), repr(f))
TypeError: set_mesh() missing 3 required positional arguments: 'verts_mask', 'edges_mask', and 'faces_mask'

enzyme69 · 2020-06-09T21:59:43Z

However SV node remote control confirmed working with SC...

aachman98 · 2020-06-10T02:27:13Z

And also getting error when sending to SV from SC.

Sorry, issue from my side. I modified the "Receive From Sorcar" node in the last few commits which allows you to get selection mask as well, but the code for Sorcar node is not yet updated.
Issue created here: aachman98/Sorcar#152
The sverchok node has no issues.

Missing "Send to Sorcar" node in SV

Testing for bugs currently, as selection mask inputs have been added to that node as well. Will be creating a separate PR for it.

hanoixan · 2021-01-24T00:02:04Z

@aachman98 Did a separate PR ever get created to add the "Send to Sorcar" node? As of now, it appears to still be missing.

nortikin · 2021-01-26T16:01:15Z

@aachman98 Did a separate PR ever get created to add the "Send to Sorcar" node? As of now, it appears to still be missing.

ATM node remote control to manipulate some values on sorcar. Or use viewer bmesh to create object and use it on any other node system

Added "Receive From Socar" generator (ext) node

8e6180d

zeffii reviewed May 25, 2020

View reviewed changes

nodes/generators_extended/receive_from_sorcar.py Outdated Show resolved Hide resolved

aachman98 added 2 commits May 25, 2020 22:15

Added icon for "Receive From Sorcar" node

3205c9a

Used ast.literal_eval in "Receive From Sorcar"node

225c3d0

aachman98 requested a review from zeffii May 25, 2020 16:54

aachman98 added 2 commits May 25, 2020 22:49

Added rst docs for "Receive From Sorcar" node

c4bb33a

Updated generators_extended_index.rst

335dfd1

zeffii approved these changes May 25, 2020

View reviewed changes

aachman98 mentioned this pull request May 25, 2020

What is the difference between Sverchok and Sorcar? #2844

Closed

aachman98 added 2 commits May 26, 2020 14:03

Improve "Receive From Sorcar" node

3fcf5c8

Minor code fix

dfe0374

aachman98 added 2 commits June 8, 2020 20:35

Updated "Receive From Sorcar" node: mask outputs

952c125

Added utility module to generate Sorcar logo

0854f68

aachman98 requested a review from zeffii June 8, 2020 15:07

aachman98 added 2 commits June 8, 2020 20:50

Fixed "Receive From Sorcar" node: set mask values

5522824

Updated "Receive From Sorcar" node docs (rst)

8c3259b

zeffii reviewed Jun 8, 2020

View reviewed changes

zeffii requested changes Jun 8, 2020

View reviewed changes

Review changes: comments, tooltips, syntax

0f93289

aachman98 requested a review from zeffii June 9, 2020 01:28

zeffii approved these changes Jun 9, 2020

View reviewed changes

zeffii merged commit aa70c65 into nortikin:master Jun 9, 2020

aachman98 mentioned this pull request Jun 10, 2020

[BUG] "Send to Sverchok" node error: missing positional arguments aachman98/Sorcar#152

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added "Receive From Socar" generator (ext) node #3281

Added "Receive From Socar" generator (ext) node #3281

aachman98 commented May 25, 2020 •

edited

Loading

zeffii left a comment

aachman98 commented May 25, 2020

zeffii commented May 25, 2020

nortikin commented May 25, 2020

Durman commented May 26, 2020

aachman98 commented May 26, 2020

zeffii commented May 26, 2020

Durman commented May 26, 2020 •

edited

Loading

aachman98 commented May 26, 2020

zeffii commented May 28, 2020 •

edited

Loading

nortikin commented Jun 7, 2020

aachman98 commented Jun 7, 2020

aachman98 commented Jun 8, 2020

zeffii Jun 8, 2020 •

edited

Loading

aachman98 Jun 9, 2020

zeffii Jun 8, 2020

aachman98 Jun 9, 2020

zeffii Jun 9, 2020

zeffii Jun 8, 2020

zeffii Jun 8, 2020

zeffii Jun 8, 2020

aachman98 Jun 9, 2020

zeffii Jun 8, 2020

zeffii left a comment

enzyme69 commented Jun 9, 2020

enzyme69 commented Jun 9, 2020

aachman98 commented Jun 10, 2020

hanoixan commented Jan 24, 2021

nortikin commented Jan 26, 2021



		def unregister():
		bpy.utils.unregister_class(SvReceiveFromSorcarNode)

Added "Receive From Socar" generator (ext) node #3281

Added "Receive From Socar" generator (ext) node #3281

Conversation

aachman98 commented May 25, 2020 • edited Loading

Addressed problem description

Solution description

Usage

Default

Referenced

Parameter updates

Preflight checklist

zeffii left a comment

Choose a reason for hiding this comment

aachman98 commented May 25, 2020

zeffii commented May 25, 2020

nortikin commented May 25, 2020

Durman commented May 26, 2020

aachman98 commented May 26, 2020

zeffii commented May 26, 2020

Durman commented May 26, 2020 • edited Loading

aachman98 commented May 26, 2020

zeffii commented May 28, 2020 • edited Loading

nortikin commented Jun 7, 2020

aachman98 commented Jun 7, 2020

aachman98 commented Jun 8, 2020

zeffii Jun 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zeffii left a comment

Choose a reason for hiding this comment

enzyme69 commented Jun 9, 2020

enzyme69 commented Jun 9, 2020

aachman98 commented Jun 10, 2020

hanoixan commented Jan 24, 2021

nortikin commented Jan 26, 2021

aachman98 commented May 25, 2020 •

edited

Loading

Durman commented May 26, 2020 •

edited

Loading

zeffii commented May 28, 2020 •

edited

Loading

zeffii Jun 8, 2020 •

edited

Loading