Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistency ouput test #4253

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Persistency ouput test #4253

wants to merge 7 commits into from

Conversation

Durman
Copy link
Collaborator

@Durman Durman commented Jul 26, 2021

Addressed problem description

Closes #4226

  1. Get json from the sverchok/json_examples folder if there is json with the same name
    in sverchok/tests/expected_tree_data folder
  2. Import json into a new tree
  3. Execute the tree
  4. Extract values from most right nodes in the tree
  5. Compare them with values from the expected_tree_data folder and raise an error if necessary
  6. Save coverage information into expected_tree_data/last_coverage.json

The test uses 45 json examples now. It covers 151 nodes what is about 22% of all nodes. But these nodes are not tested even in half of their possible modes. So total coverage is estimated about 9%. It means that there is work ahead in this direction. It would be cool if examples in the documentation to each node could be imported too. In this case they could be used in the test and coverage would be much better.

Preflight checklist

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete.
  • Ready for merge.

@Durman Durman marked this pull request as draft July 27, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistency of node output data
1 participant