Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate Breadcrumbs component from layout to current page #63

Closed
mhuggins opened this issue Apr 11, 2018 · 0 comments
Closed

Relocate Breadcrumbs component from layout to current page #63

mhuggins opened this issue Apr 11, 2018 · 0 comments

Comments

@mhuggins
Copy link
Contributor

mhuggins commented Apr 11, 2018

Having the AuthenticatedLayout component render the Breadcrumbs component doesn't make sense because it's not aware of the current route. Instead, the current page's component should directly render Breadcrumbs as its first child, with the rest of its child components/markup following.

@mhuggins mhuggins changed the title Relocate Breadcrumb component from layout to current page Relocate Breadcrumbs component from layout to current page Apr 11, 2018
@jeroenptrs jeroenptrs removed the work in progress Open PR or an issue linked to an open PR label May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants