Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): adjust the way errors are returned #1072

Merged
merged 1 commit into from Aug 11, 2019

Conversation

DalderupMaurice
Copy link
Member

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Aug 11, 2019
@codecov
Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #1072 into develop will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop    #1072   +/-   ##
========================================
  Coverage    50.82%   50.82%           
========================================
  Files          240      240           
  Lines         2064     2064           
  Branches       275      275           
========================================
  Hits          1049     1049           
  Misses         843      843           
  Partials       172      172

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 11, 2019
@DalderupMaurice DalderupMaurice merged commit d1fe33b into develop Aug 11, 2019
@DalderupMaurice DalderupMaurice deleted the chore/adjust-error-handling branch August 11, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants