Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): set minimum window size #835

Merged
merged 2 commits into from Jan 15, 2019
Merged

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Jan 15, 2019

Description

set minimum window size

Motivation and Context

you could have it 20x20px

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #737

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #835 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #835   +/-   ##
========================================
  Coverage    54.37%   54.37%           
========================================
  Files          227      227           
  Lines         1953     1953           
  Branches       269      269           
========================================
  Hits          1062     1062           
  Misses         735      735           
  Partials       156      156

@DalderupMaurice DalderupMaurice merged commit 7f1e087 into develop Jan 15, 2019
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jan 15, 2019
@DalderupMaurice DalderupMaurice deleted the chore/window-min-size branch January 15, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set minimum window size
1 participant