Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoUpdates): check for updates during splashscreen and added user feedback #853

Merged
merged 4 commits into from
Jan 24, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Jan 24, 2019

Description

check for updates during splashscreen and added user feedback in the splash screen

Motivation and Context

This prevents the client from starting during downloading/installing the client which might make users think it's crashing

How Has This Been Tested?

manually

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #853 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #853   +/-   ##
========================================
  Coverage    54.54%   54.54%           
========================================
  Files          227      227           
  Lines         1958     1958           
  Branches       270      270           
========================================
  Hits          1068     1068           
  Misses         733      733           
  Partials       157      157

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jan 24, 2019
@DalderupMaurice DalderupMaurice merged commit e121882 into develop Jan 24, 2019
@DalderupMaurice DalderupMaurice deleted the chore/auto-update-fix branch January 24, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant