Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(network): fix network reselection on startup #902

Merged
merged 2 commits into from
Feb 28, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Feb 27, 2019

Description

fix network reselection on startup

Motivation and Context

It selected incorrectly

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #899

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Feb 27, 2019
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #902 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #902   +/-   ##
========================================
  Coverage    52.45%   52.45%           
========================================
  Files          231      231           
  Lines         1977     1977           
  Branches       272      272           
========================================
  Hits          1037     1037           
  Misses         776      776           
  Partials       164      164

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Feb 28, 2019
@DalderupMaurice DalderupMaurice merged commit 496dcb8 into develop Feb 28, 2019
@DalderupMaurice DalderupMaurice deleted the chore/fix-network-reselect branch February 28, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected network is set to latest custom network on start
2 participants