Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(txPanel): filter tokenlist to only contain tokens you have #917

Merged
merged 8 commits into from
Mar 10, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Mar 10, 2019

Description

  • filter tokenlist to only contain tokens you have
  • prioritize nOS in dropdown list
  • sync master/dev branch

Motivation and Context

needed changes for release 0.5.2

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

Maurice Dalderup added 8 commits January 13, 2019 16:12
@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #917 into develop will increase coverage by 0.04%.
The diff coverage is 44.44%.

@@             Coverage Diff             @@
##           develop     #917      +/-   ##
===========================================
+ Coverage    52.39%   52.43%   +0.04%     
===========================================
  Files          235      235              
  Lines         2006     2010       +4     
  Branches       274      275       +1     
===========================================
+ Hits          1051     1054       +3     
  Misses         791      791              
- Partials       164      165       +1

1 similar comment
@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #917 into develop will increase coverage by 0.04%.
The diff coverage is 44.44%.

@@             Coverage Diff             @@
##           develop     #917      +/-   ##
===========================================
+ Coverage    52.39%   52.43%   +0.04%     
===========================================
  Files          235      235              
  Lines         2006     2010       +4     
  Branches       274      275       +1     
===========================================
+ Hits          1051     1054       +3     
  Misses         791      791              
- Partials       164      165       +1

@DalderupMaurice DalderupMaurice merged commit a439624 into develop Mar 10, 2019
@DalderupMaurice DalderupMaurice deleted the chore/prioritize-nos branch March 10, 2019 12:58
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant