Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): split previous auth values for profile and #926

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Mar 11, 2019

Description

splits auth state of profile dropdown and encrypted key w/ password

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #926 into develop will decrease coverage by 0.13%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           develop    #926      +/-   ##
==========================================
- Coverage    52.43%   52.3%   -0.14%     
==========================================
  Files          235     236       +1     
  Lines         2010    2019       +9     
  Branches       275     277       +2     
==========================================
+ Hits          1054    1056       +2     
- Misses         791     796       +5     
- Partials       165     167       +2

@DalderupMaurice DalderupMaurice merged commit e88f996 into develop Mar 11, 2019
@DalderupMaurice DalderupMaurice deleted the chore/auth-split branch March 11, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant