Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ledger): fix runtimeGenerator issue with ledger #928

Merged
merged 3 commits into from
Mar 14, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Mar 14, 2019

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #928 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #928   +/-   ##
========================================
  Coverage    52.35%   52.35%           
========================================
  Files          236      236           
  Lines         2021     2021           
  Branches       277      277           
========================================
  Hits          1058     1058           
  Misses         796      796           
  Partials       167      167

@DalderupMaurice DalderupMaurice changed the title chore(ledger): add polyfilll chore(ledger): fix runtimeGenerator issue with ledger Mar 14, 2019
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Mar 14, 2019
@DalderupMaurice DalderupMaurice merged commit a458086 into develop Mar 14, 2019
@DalderupMaurice DalderupMaurice deleted the chore/ledger-fix branch March 14, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant