Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugins] Handle multiprocess & cover together #841

Merged
merged 2 commits into from
Apr 4, 2015

Conversation

nicolasgrasset
Copy link
Contributor

Addressing issue #820 and #710

I am relying on coverage's own method to run in parallel and store each worker's coverage in a separate .coverage file that gets combined in the report() method.

@jszakmeister jszakmeister added this to the 1.4.0 milestone Oct 24, 2014
@jszakmeister
Copy link
Contributor

I'm sure you tested it, but I just want to double check: does this actually produce a useful coverage report with this change? Any gotchas?

@nicolasgrasset
Copy link
Contributor Author

Awesome @jszakmeister, yes for sure. We've been using it in our continuous integration stack for the past few weeks and it works great.

@jszakmeister
Copy link
Contributor

Good to know. Thank you. I'm looking to include this in 1.4.0.

@gst
Copy link

gst commented Nov 3, 2014

Hi,
about this:
just to know when the 1.4.0 release is foreseen ? more or less.. if you have an idea.

@jszakmeister
Copy link
Contributor

@gst Sorry, I don't have a date in mind. It really depends on how bogged down I get at work. It probably won't happen until the end of the year, or early next year. Things tend to slow down around then, and I can take some extra time off work to wrap up loose ends.

@dhirschfeld
Copy link

I tried this branch out on a large test-suite with --processes=20 and after a short while all tests fail with IOError: [Errno 232] The pipe is being closed

Python 2.7, win64

@nicolasgrasset
Copy link
Contributor Author

I could not reproduce the issue with Python 2.7 on OSX and running with --processes=20.

Could it be that any part of your app/tests is not thread-safe?

@jszakmeister jszakmeister removed this from the 1.4.0 milestone Apr 4, 2015
jszakmeister added a commit that referenced this pull request Apr 4, 2015
[plugins] Handle multiprocess & cover together
@jszakmeister jszakmeister merged commit 3151de8 into nose-devs:master Apr 4, 2015
@jszakmeister
Copy link
Contributor

Thank you @fellowshipofone! Sorry it took so long to get merged.

@nicolasgrasset
Copy link
Contributor Author

Awesome, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants