Remember panel height when creating it

[sryze]

Fixes #31

[noseglid]

I didn't get around to give this a whirl yet, but just looking at the code it seems as the build panel will attach regardless of the keepVisible configuration.

I'll check this out in more depth tomorrow. Thanks for your contribution!

[sryze]

It will attach, yeah, but then it'll also detach once keepVisible is read from the config if it's false.

It seems like there might be a problem with double attach though (if keepVisible is true). Should I check if the panel has been already created in attach?

[noseglid]

Is you acutely pointed out, when we call atom.config.observe with the keepVisible argument, visibleFromConfig will be called with the current choice the user have. This attach is not necessary then, because it will be either attach or detach att that point.

[sryze]

But then if we remove this attach this.height will be uninitialized when minimizedHeight gets loaded from the config.

The whole point was that we need to get the height of the panel while it still exists beacuse otherwise the height will be 0. And since the panel might not have been ever made visible prior to reading minimizedHeight we need to explicitly create it somewhere.

Changing the order of observe calls might work too I guess, but this seemed more reliable and I wasn't sure if they are synchronous or not.

[noseglid]

Ah. I see.

You are correct. I think this is the best way too, and it works well. Thanks!

[noseglid]

The problem with multiple attach, if it is that the .bottom.tool-panel.panel-bottom element is left (which gives an increasing black bar at the bottom). I found this while testing your fixed and corrected it in 8b182af. (by always destroying it before creating a new one).

[noseglid]

Thanks! I will include this in next release (v0.23.0).