Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): add new star icons #147

Merged
merged 2 commits into from
Dec 9, 2018
Merged

feat(icons): add new star icons #147

merged 2 commits into from
Dec 9, 2018

Conversation

4k1k0
Copy link
Contributor

@4k1k0 4k1k0 commented Dec 9, 2018

I made 2 new star icons. One is half filled with color and the other one it's transparent. I hope this can be used as a "star ranking system".

captura de pantalla_2018-12-09_13-59-48

jjspace
jjspace approved these changes Dec 9, 2018
View reviewed changes
Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good idea to have partial/empty stars for ranks 👍

abdallahalsamman
abdallahalsamman approved these changes Dec 9, 2018
View reviewed changes
Copy link
Member

@abdallahalsamman abdallahalsamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@4k1k0 good idea!

Thanks for the PR 🙏

@abdallahalsamman abdallahalsamman merged commit 11ce7b8 into nostalgic-css:develop Dec 9, 2018
@BcRikko
Copy link
Member

BcRikko commented Dec 9, 2018

is-empty seems better than is-transparent 🤔

All other icons use is-empty 🙏

NES.css/scss/icons/icons.scss

Lines 42 to 47 in 617999c

&.heart::before {
@include pixelize($icon-heart, $icon-heart-colors, $px);
}
&.heart.is-empty::before {
@include pixelize($icon-heart-empty, $icon-heart-empty-colors, $px);
}

I'll fix it later 🛠

@BcRikko BcRikko mentioned this pull request Dec 9, 2018
Closed
@abdallahalsamman
Copy link
Member

@BcRikko that got through me 🙈

Thanks for taking the time to review this @BcRikko 🙏🙏

@4k1k0 4k1k0 deleted the new-stars branch December 11, 2018 04:56
@BcRikko
Copy link
Member

BcRikko commented Dec 18, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjspace jjspace jjspace approved these changes

@abdallahalsamman abdallahalsamman abdallahalsamman approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@4k1k0 @BcRikko @abdallahalsamman @jjspace