Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Korean translation of CONTRIBUTING.md #465

Merged
merged 5 commits into from
Jul 13, 2021
Merged

Added Korean translation of CONTRIBUTING.md #465

merged 5 commits into from
Jul 13, 2021

Conversation

tank3a
Copy link
Contributor

@tank3a tank3a commented Jul 13, 2021

464 Issue

Added Korean translation of CONTRIBUTING.md and added CONTRIBUTING-ko link to other versions of CONTRIBUTING.

@tank3a
Copy link
Contributor Author

tank3a commented Jul 13, 2021

What does it mean by
✖ subject may not be empty [subject-empty]
✖ type may not be empty [type-empty]
from failed details?

@guastallaigor guastallaigor self-requested a review July 13, 2021 12:57
@guastallaigor
Copy link
Member

guastallaigor commented Jul 13, 2021 •
edited
Loading

Hey @tank3a

Unfortunately commitlint has failed.

Could you change your commit message to something like docs: add korean contributing translation file 🙇

# edit your commit message
$ git commit --amend -m "docs: add korean contributing translation file"

# force push branch
$ git push --force-with-lease origin update-docs

@guastallaigor guastallaigor added the documentation Adding, removing, or updating documentation label Jul 13, 2021
guastallaigor
guastallaigor approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@guastallaigor guastallaigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I can't really review the korean translations, but I will take your word for it 😄
Just please fix the commit message to pass commitlint and I will merge it.

@guastallaigor guastallaigor added the waiting - contributor Waiting for the contributor to address some situations label Jul 13, 2021
@tank3a
Copy link
Contributor Author

tank3a commented Jul 13, 2021

I guess I changed.. or maybe messed up, but now the test is passed! Thank you!

@guastallaigor guastallaigor merged commit 17fcd56 into nostalgic-css:develop Jul 13, 2021
@guastallaigor guastallaigor removed the waiting - contributor Waiting for the contributor to address some situations label Jul 13, 2021
@guastallaigor guastallaigor mentioned this pull request Jul 13, 2021
Closed
@tank3a tank3a deleted the update-docs branch July 13, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guastallaigor guastallaigor guastallaigor approved these changes

Assignees

@tank3a tank3a

Labels
documentation Adding, removing, or updating documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tank3a @guastallaigor