Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Korean translation of CONTRIBUTING.md #464

Closed
tank3a opened this issue Jul 12, 2021 · 4 comments
Closed

Adding Korean translation of CONTRIBUTING.md #464

tank3a opened this issue Jul 12, 2021 · 4 comments
Assignees
Labels
documentation Adding, removing, or updating documentation

Comments

@tank3a
Copy link
Contributor

tank3a commented Jul 12, 2021

I found there are no documentations translated in Korean, and if I can, I'll be willing to contributing on making ko-translated documents, starting from CONTRIBUTING.md.

@guastallaigor
Copy link
Member

Hello @tank3a , thank you for your message.
To be honest with you, we are not working actively on this project for a while now.
I've been trying to maintain it from time to time, however I don't have access/authorization to accept new features or publish new releases.
So you could create it, however I could only merge it to the develop branch, and not sure when we could merge it to master.
I do apologize, but I don't think there's much more I can do here.
Thank you again.

@guastallaigor guastallaigor added the documentation Adding, removing, or updating documentation label Jul 12, 2021
@tank3a
Copy link
Contributor Author

tank3a commented Jul 13, 2021

@guastallaigor oh thank's for your comment and I'm sorry to hear that. Actually I've already made the Korean translation. As this is my first contribution to the open source, even if it cannot be merged to master right now.. I feel this is also awesome experience and want to PR.
Again I really appreciate your comment even on "discontinued(I guess?)", explaining me how this project is going on, and your help.

@guastallaigor
Copy link
Member

@tank3a Sure thing. I've already reviewed your PR, after fixing the commit message I can merge it.
Thank you for your understanding.

@guastallaigor
Copy link
Member

ref #465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Adding, removing, or updating documentation
Projects
None yet
Development

No branches or pull requests

2 participants