NIP-15 must be mandatory #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sending an `EOSE` message from the relay must be mandatory not optional.
|
just fyi, you don't need to create a new PR every time you need to make a change, just add a new commit to the branch 😉 -- otherwise discussions are lost |
|
Thanks man. it's too late here and I ran out of caffeine 😄 |
fiatjaf
reviewed
Apr 7, 2023
15.md
Outdated
|
|
||
| The motivation for this proposal is to reduce uncertainty when all events have been sent by a relay to make client code possibly less complex. | ||
| Clients may use the `supported_nips` field to learn if a relay supports end of stored events notices. | ||
| Clients MUST unsubscribe when they get an `EOSE` message from the relay. |
There was a problem hiding this comment.
Suggested change
| Clients MUST unsubscribe when they get an `EOSE` message from the relay. |
fiatjaf
reviewed
Apr 7, 2023
Semisol
reviewed
Apr 7, 2023
Co-authored-by: Semisol <45574030+Semisol@users.noreply.github.com>
|
Sorry for asking you to open this PR, but I've decided it would be simpler and clearer for everybody to just merge NIP-15 into NIP-01. |
great decision 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sending an
EOSEmessage from the relayMUSTbemandatorynot optional.