Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIP-15 must be mandatory #421

Closed
wants to merge 3 commits into from
Closed

NIP-15 must be mandatory #421

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82ff18c
make NIP-15 mandatory
sepehr-safari Apr 7, 2023
951bff0
NIP-15 must be mandatory
sepehr-safari Apr 7, 2023
8128028
Apply suggestions from code review
sepehr-safari Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions 15.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,14 @@ NIP-15
End of Stored Events Notice
---------------------------

`final` `optional` `author:Semisol`
`final` `mandatory` `author:Semisol`

Relays may support notifying clients when all stored events have been sent.
Relays MUST support notifying clients when all stored events have been sent.

If a relay supports this NIP, the relay SHOULD send the client a `EOSE` message in the format `["EOSE", <subscription_id>]` after it has sent all the events it has persisted and it indicates all the events that come after this message are newly published.
The relay MUST send the client an `EOSE` message in the format `["EOSE", <subscription_id>]` after it has sent all the events it has persisted and it indicates all the events that come after this message are newly published.

Client Behavior
---------------

Clients SHOULD use the `supported_nips` field to learn if a relay supports end of stored events notices.

Motivation
----------

The motivation for this proposal is to reduce uncertainty when all events have been sent by a relay to make client code possibly less complex.
Clients may use the `supported_nips` field to learn if a relay supports end of stored events notices.
Clients MUST unsubscribe when they get an `EOSE` message from the relay.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Clients MUST unsubscribe when they get an `EOSE` message from the relay.

sepehr-safari marked this conversation as resolved.
Show resolved Hide resolved
sepehr-safari marked this conversation as resolved.
Show resolved Hide resolved