Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind 16 generic reposts #610

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Kind 16 generic reposts #610

merged 1 commit into from
Jun 18, 2023

Conversation

fiatjaf
Copy link
Member

@fiatjaf fiatjaf commented Jun 16, 2023

Solving #576.

@staab
Copy link
Member

staab commented Jun 16, 2023

Do you mind if I use this for implementing moderation for public groups?

@fiatjaf
Copy link
Member Author

fiatjaf commented Jun 16, 2023

Why not make a new kind?

@staab
Copy link
Member

staab commented Jun 16, 2023

I'm mostly joking, I won't use this because I don't use reposts in Coracle, but I do support nevent embeds, which currently are breaking kind 1's based on your concept of composition being non-interoperable, this PR doesn't solve that.

@fiatjaf
Copy link
Member Author

fiatjaf commented Jun 17, 2023

Everybody supports nevent embeds, I don't think they are breaking. I also am not a radical about not having composition, I just think people shouldn't be radical about having full composability.

@staab
Copy link
Member

staab commented Jun 17, 2023

Interesting, what is the difference between a re-post and an embed, other than the added context?

@fiatjaf
Copy link
Member Author

fiatjaf commented Jun 17, 2023

It's the same. The embed is a quote-repost and vice-versa. That's how Twitter works too. The canonical content of a Twitter quote-repost is just a comment plus a link to the other tweet.

NIP-18 reposts are pure reposts, with no added comments.

@mikedilger
Copy link
Contributor

mikedilger commented Jun 17, 2023

ACK

(I like this because as a different event kind, I can ignore them)

@vitorpamplona
Copy link
Collaborator

Can we change the advice to add the event into .content for 16?

It SHOULD contain the stringified JSON of the reposted note event for a quick look up.

@vitorpamplona
Copy link
Collaborator

vitorpamplona commented Jun 18, 2023

Amethyst v60+ supports this change. Kind 1s will be boosted with kind 6 and everything else with kind 16, the k tag and the event in .content. All generic boosts are shown in the feed just like kind 6s are.

@fiatjaf
Copy link
Member Author

fiatjaf commented Jun 18, 2023

Great. Thanks!

@fiatjaf
Copy link
Member Author

fiatjaf commented Jun 18, 2023

Can we change the advice to add the event into .content for 16?

I've changed this on a separate commit.

@fiatjaf fiatjaf merged commit 7668507 into master Jun 18, 2023
@fiatjaf fiatjaf deleted the generic-reposts branch June 18, 2023 14:30
@arthurfranca
Copy link
Contributor

People will use kind 6 to repost all event kinds and also kind 16 with k: ["1"] tag ^_^

@fiatjaf
Copy link
Member Author

fiatjaf commented Jun 18, 2023

Do you think?

@fiatjaf
Copy link
Member Author

fiatjaf commented Jun 18, 2023

habla.news has also already stopped sending kind:6 and is sending kind:16 now: verbiricha/habla.news@026b678

@arthurfranca
Copy link
Contributor

just kidding xd
I think main clients will follow spec and that's what matters most

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants