New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wording to imply that reactions can target any event #815
Conversation
Why is it causing trouble to clients that only handle kind 1? |
Rabbit assumes only kind 1 and does not correctly display reactions of kind 42. |
This makes no sense. reactions can work on any note, not just kind 1
|
How about adding the |
Line 10 in 21c6c12
I think that "note" is not clear. Should be use "event" instead. |
On Tue, Oct 10, 2023 at 11:27:19PM -0700, Asai Toshiya wrote:
> This makes no sense. reactions can work on any note, not just kind 1
https://github.com/nostr-protocol/nips/blob/21c6c12c524cb71f18e068c9bcf223cda0214b5f/25.md?plain=1#L10
I think that "note" is not clear. Should be use "event" instead.
These terms are interchangeable, although these days I prefer notes to
mean the actual json, and events to be things like ["EVENT", note]
|
I think it's better to fix Rabbit in this case. |
Rabbit shows who the reaction is from but not the target |
Makes sense. Let's edit the text to say |
May I use the |
You are free to use the |
I have to look for a few reactions to |
ACK for the optional use of the k tag. NACK for creating another reaction event. |
NACK all, |
Thank you for creating this PR. I'm okay if it is optional. There are possible several use-cases (but I'm not going to implement as for now, and I'm not confident with this is useful):
|
kind 17
) in the same way as "generic reposts" (kind 16
)kind 1
events will not need additional support, and clients reacting to events other thankind 1
events will be able to handle the kind they want.I am developing a client for Public Chat (NIP-28) that can react to
kind 42
events.However, it is causing troubles for other clients that only handle
kind 1
events.In addition, I only want to handle reactions to
kind 42
events.So I want to use generic reactions containing the
k
tag.