Relay Requests Encoding and Tests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
joelklabo
changed the title
joelklabo
force-pushed
the
joel/relay-requests
branch
2 times, most recently
from
8491c97
to
be1221e
Compare
joelklabo
force-pushed
the
joel/relay-requests
branch
from
be1221e
to
d60702d
Compare
joelklabo
changed the title
bryanmontz
reviewed
May 27, 2023
Sources/NostrSDK/Filter.swift
Outdated
|
|
||
| import Foundation | ||
|
|
||
| struct Filter { |
There was a problem hiding this comment.
I'm hoping that we might be able to have this raw filter private to the library, and expose a filter type to the client app that uses native types, such as a NostrKind enum for the kinds part of the filter and Keypair types for the pubkeys. It could be converted the raw type when making requests, but that can come later.
There was a problem hiding this comment.
What do you think we should for this right now? I think when we start setting up the public API we should definitely do that but not sure if we need to now. What do you think?
bryanmontz
approved these changes
May 28, 2023
RandyMcMillan
pushed a commit
to RandyMcMillan/nostr-sdk-ios
that referenced
this pull request
Sep 1, 2024
* Implement RelayRequest with Tests * remove self. and use new if let syntax * remove unnecessary codable implementation * use full request for name * use XCTUnwrap * test JSON equality protocol extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15