Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read events from relays #57

Merged
merged 9 commits into from
Jun 20, 2024
Merged

Read events from relays #57

merged 9 commits into from
Jun 20, 2024

Conversation

Sebastix
Copy link
Member

@Sebastix Sebastix commented Jun 18, 2024

Full implementation of reading events from relays.

kriptonix and others added 3 commits June 11, 2024 13:08
…f setPTag method to setLowercasePTags, changed name of setETags method to setLowercaseETags
* Adds the feature reading events from a relay
@Sebastix Sebastix self-assigned this Jun 18, 2024
* feature to read events from multiple relay with a new RelaySet class
* optimized the RequestMessage class after the work done by @kriptonix
* added a MessageTypeEnum used for different type of messages send to the relay
* updated the README.md with example how to read events
* updated the roadmap in the README.md
@Sebastix Sebastix marked this pull request as ready for review June 18, 2024 16:29
@Sebastix Sebastix changed the title Feat/read from relay Read events from relays Jun 18, 2024
@kriptonix
Copy link
Contributor

I tested and it works fine. Just noticed one small mistake in README. In line 133 should be "$request = new Request($relay, $requestMessage);" not "$request = new Request($relayUrl, $requestMessage);". Instead of using $relayUrl when creating new Request we should use Relay object. Maybe you could change this directly not to make PR for this small correction.

@Sebastix
Copy link
Member Author

I tested and it works fine. Just noticed one small mistake in README. In line 133 should be "$request = new Request($relay, $requestMessage);" not "$request = new Request($relayUrl, $requestMessage);". Instead of using $relayUrl when creating new Request we should use Relay object. Maybe you could change this directly not to make PR for this small correction.

Thx!
Updated the README.md :)

@Sebastix Sebastix merged commit 859ff95 into main Jun 20, 2024
3 checks passed
@Sebastix Sebastix deleted the feat/read_from_relay branch August 16, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants