SIB decorates hash / array by underlying type only, not schema #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n SchemaInstanceBase initialize to decide to extend with SchemaInstanceBaseHash / SchemaInstanceBaseArray. I think it doesn't make sense for this to check the schema. although it is a bit unexpected for a SIB instance for a schema the descirbes an array to have hash methods, it is better that SIB just wrap the node per its type. more often the schema doesn't specify its type, and it is not desirable for scorpio to fail to decorate an instance as a hash due to a more open ended schema.
…es always extended with SIBH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no longer checking schema.describes_hash? / schema.describes_array? on SchemaInstanceBase initialize to decide to extend with SchemaInstanceBaseHash / SchemaInstanceBaseArray.