-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated quickstart guide to fix #283 #284
Updated quickstart guide to fix #283 #284
Conversation
✅ Deploy Preview for notarydev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@Roseline-Bassey Thanks. Could you resolve the DCO issue by signing your commits? See https://github.com/notaryproject/notaryproject.dev/pull/284/checks?check_run_id=14238319690 |
cc @zr-msft |
@Roseline-Bassey changes to the quickstart LGTM, but what are the changes to the troubleshooting.md? They seem unrelated to the PR description and linked issue. |
Hi @zr-msft , thanks for the feedback. The changes to troubleshooting.md can be found here |
@Roseline-Bassey thank you for linking to the other PR, but you need to fix both of these PRs:
|
I acknowledge the mix-up. I'm working on fixing both PR. Thanks for your feedback. |
Signed-off-by: Roseline <roselynbassey23@gmail.com>
Signed-off-by: Roseline <roselynbassey23@gmail.com>
Signed-off-by: Zach Rhoads <zachary.rhoads@microsoft.com> Signed-off-by: Roseline <roselynbassey23@gmail.com>
89a0054
to
b9f80c0
Compare
Hi, everyone I have fixed all issues related to this PR in a new PR. Please kindly have a look. |
Should this PR be closed since it is not valid any more? |
Yes, it should. Thank you. |
@Roseline-Bassey Let's close PR as the changes have been included in another PR. |
This PR fixed #283
I have updated the
docker inspect
command in the quickstart guide to rightly inspect the sample image.I also updated its output.