Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated quickstart guide to fix #283 #284

Closed

Conversation

Roseline-Bassey
Copy link
Contributor

@Roseline-Bassey Roseline-Bassey commented Jun 13, 2023

This PR fixed #283

I have updated the docker inspect command in the quickstart guide to rightly inspect the sample image.
I also updated its output.

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit b9f80c0
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/648ceba4b24fdc00089e6d36
😎 Deploy Preview https://deploy-preview-284--notarydev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Roseline-Bassey Roseline-Bassey changed the title Roseline branch Updated quickstart guide to fix #283 Jun 13, 2023
@FeynmanZhou
Copy link
Member

FeynmanZhou commented Jun 15, 2023

@Roseline-Bassey Thanks. Could you resolve the DCO issue by signing your commits? See https://github.com/notaryproject/notaryproject.dev/pull/284/checks?check_run_id=14238319690

@FeynmanZhou
Copy link
Member

cc @zr-msft

@zr-msft
Copy link
Collaborator

zr-msft commented Jun 15, 2023

@Roseline-Bassey changes to the quickstart LGTM, but what are the changes to the troubleshooting.md? They seem unrelated to the PR description and linked issue.

iamsamirzon
iamsamirzon previously approved these changes Jun 15, 2023
@Roseline-Bassey
Copy link
Contributor Author

@Roseline-Bassey changes to the quickstart LGTM, but what are the changes to the troubleshooting.md? They seem unrelated to the PR description and linked issue.

Hi @zr-msft , thanks for the feedback. The changes to troubleshooting.md can be found here

@zr-msft
Copy link
Collaborator

zr-msft commented Jun 16, 2023

@Roseline-Bassey thank you for linking to the other PR, but you need to fix both of these PRs:

@Roseline-Bassey
Copy link
Contributor Author

@Roseline-Bassey thank you for linking to the other PR, but you need to fix both of these PRs:

I acknowledge the mix-up. I'm working on fixing both PR. Thanks for your feedback.

roseline and others added 3 commits June 17, 2023 00:08
Signed-off-by: Roseline <roselynbassey23@gmail.com>
Signed-off-by: Roseline <roselynbassey23@gmail.com>
Signed-off-by: Zach Rhoads <zachary.rhoads@microsoft.com>
Signed-off-by: Roseline <roselynbassey23@gmail.com>
@Roseline-Bassey
Copy link
Contributor Author

Hi, everyone

I have fixed all issues related to this PR in a new PR. Please kindly have a look.

@yizha1
Copy link
Contributor

yizha1 commented Jun 19, 2023

Should this PR be closed since it is not valid any more?

@Roseline-Bassey
Copy link
Contributor Author

Should this PR be closed since it is not valid any more?

Yes, it should. Thank you.

@FeynmanZhou
Copy link
Member

FeynmanZhou commented Jun 20, 2023

@Roseline-Bassey Let's close PR as the changes have been included in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the quickstart guide "docker inspect" section to rightly inspect the image digest for signing
5 participants