Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated quickstart.md file #289

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

Roseline-Bassey
Copy link
Contributor

This PR fixed #283

I have updated the docker inspect command in the quickstart guide to rightly inspect the sample image.

Signed-off-by: Roseline <roselynbassey23@gmail.com>
@netlify
Copy link

netlify bot commented Jun 17, 2023

Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit 108a93e
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/648e0c3cb04ecd0008145e6b
😎 Deploy Preview https://deploy-preview-289--notarydev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou
Copy link
Member

Thanks @Roseline-Bassey for taking this issue and fixing it.

@FeynmanZhou
Copy link
Member

@yizha1 @zr-msft @iamsamirzon @priteshbandi Could you pls also review it?

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Roseline-Bassey, nice catch. LGTM

@Roseline-Bassey
Copy link
Contributor Author

You're welcome @FeynmanZhou and @yizha1

@FeynmanZhou FeynmanZhou merged commit 370e511 into notaryproject:main Jun 19, 2023
6 checks passed
Roseline-Bassey added a commit to Roseline-Bassey/notaryproject.dev that referenced this pull request Jul 18, 2023
Signed-off-by: Roseline <roselynbassey23@gmail.com>
Roseline-Bassey added a commit to Roseline-Bassey/notaryproject.dev that referenced this pull request Jul 18, 2023
Signed-off-by: Roseline <roselynbassey23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the quickstart guide "docker inspect" section to rightly inspect the image digest for signing
3 participants