Skip to content

Commit

Permalink
clean up
Browse files Browse the repository at this point in the history
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
  • Loading branch information
Two-Hearts committed Jul 3, 2024
1 parent 99bf5e7 commit aa3903d
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/e2e-test-sign.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ jobs:
echo "target_artifact_reference=localhost:5000/image1@${{ steps.image1.outputs.digest }}" >> "$GITHUB_ENV"
echo "target_artifact_reference2=localhost:5000/image2@${{ steps.image2.outputs.digest }}" >> "$GITHUB_ENV"
# # Setting up Notation CLI on the runner
# - name: Setup Notation
# uses: ./setup
# Setting up Notation CLI on the runner
- name: Setup Notation
uses: ./setup

# # Generate test
# - name: Notation generate-test
# run: |
# notation cert generate-test "e2e-test"
# Generate test
- name: Notation generate-test
run: |
notation cert generate-test "e2e-test"
# E2E test cases on Notation Sign
- name: Sign artifact using notation plugin
Expand Down
2 changes: 1 addition & 1 deletion dist/sign.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/sign.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ async function sign(): Promise<void> {
}
}
if (targetArtifactReferenceList.length === 0) {
throw new Error("input target_artifact_reference does not contain any valid reference")
throw new Error("input target_artifact_reference does not contain any valid reference");
}

// setting up notation signing plugin
Expand Down Expand Up @@ -113,7 +113,7 @@ async function setupPlugin() {
console.log("installing signing plugin via Notation...");
await exec.getExecOutput('notation', ['plugin', 'install', '--url', plugin_url, '--sha256sum', plugin_checksum]);
return;
}
}

// download signing plugin, validate checksum and plugin name
console.log("downloading signing plugin...");
Expand Down

0 comments on commit aa3903d

Please sign in to comment.