Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the version value of useragent in the signature should be driven by notation release value #233

Open
priteshbandi opened this issue Dec 7, 2022 · 2 comments
Open

the version value of useragent in the signature should be driven by notation release value #233

priteshbandi opened this issue Dec 7, 2022 · 2 comments
Milestone
Discuss

Comments

@priteshbandi
Copy link
Contributor

notation-go/signer/signer.go

Line 24 in 0355e8e

const signingAgent = "Notation/1.0.0"

The semver, currently 1.0.0 should be set based on notation release which means the value needs to be taken as input from caller of sign method.
@priteshbandi priteshbandi added this to the RC-2 milestone Dec 7, 2022
@priteshbandi
Copy link
Contributor Author

Adding it as rc2 so that we can triage.

@priteshbandi
Copy link
Contributor Author

This is partially complete;

  1. For SignatureGenerator the fix was done as part of Add additional header validation for payload #178
  2. For EnvelopeGenerator fix is pending

@priteshbandi priteshbandi modified the milestones: RC-2, RC-4 Feb 28, 2023
@yizha1 yizha1 modified the milestones: RC-4, Discuss Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Notary Project Planning Board
Status: Todo
Milestone
Discuss
Development

No branches or pull requests
2 participants
@priteshbandi @yizha1