Add additional header validation for payload #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgnote
reviewed
Nov 3, 2022
priteshbandi
reviewed
Nov 4, 2022
jondonas
force-pushed
the
main
branch
2 times, most recently
from
4420171
to
8188db6
Compare
|
@priteshbandi can review to close the issue tied to" Tracks multiple TODOs in signature package#80" |
3 tasks
3 tasks
|
@jondonas could you rebase this PR first? |
jondonas
force-pushed
the
main
branch
3 times, most recently
from
91743a4
to
900528f
Compare
shizhMSFT
reviewed
Dec 1, 2022
jondonas
force-pushed
the
main
branch
2 times, most recently
from
61519b7
to
2c7aa15
Compare
priteshbandi
reviewed
Dec 5, 2022
Signed-off-by: Jonathan Donas <jddonas@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses TODO's tracked in Issue 80
Note that new tests for NewSignerFromFiles were already added back in September
Validations around no top-level attributes being added are from 5.c.c in the spec
Signed-off-by: Jonathan Donas jddonas@amazon.com