Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e test cases for flag --insecure-registry #679

Merged
merged 12 commits into from
May 25, 2023

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented May 23, 2023

Feature:

  • add E2E testing TLS support for Github Action environment

Test:

  • added --insecure-registry test for sign, verify, inspect, list

Note login command E2E test cases are not included in the PR because it needs to setup credential store in Github Action and should be done in another PR. Added an issue to track it #680

Resolves #633
Signed-off-by: Junjie Gao junjiegao@microsoft.com

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #679 (88c9231) into main (5fdefed) will increase coverage by 3.55%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
+ Coverage   61.35%   64.91%   +3.55%     
==========================================
  Files          42       40       -2     
  Lines        2280     2183      -97     
==========================================
+ Hits         1399     1417      +18     
+ Misses        782      651     -131     
- Partials       99      115      +16     

see 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao changed the title feat: add TLS support for E2E testing test: add e2e test cases for flag --plain-http May 23, 2023
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao changed the title test: add e2e test cases for flag --plain-http test: add e2e test cases for flag --insecure-registry May 23, 2023
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
test/e2e/internal/notation/registry.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/registry.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/init.go Show resolved Hide resolved
test/e2e/suite/command/inspect.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
test/e2e/suite/command/sign.go Show resolved Hide resolved
test/e2e/suite/command/sign.go Outdated Show resolved Hide resolved
test/e2e/suite/command/verify.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT previously approved these changes May 24, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
test/e2e/suite/command/verify.go Outdated Show resolved Hide resolved
test/e2e/suite/command/verify.go Outdated Show resolved Hide resolved
test/e2e/internal/utils/matcher.go Outdated Show resolved Hide resolved
test/e2e/internal/utils/matcher.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/registry.go Show resolved Hide resolved
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 98f5290 into notaryproject:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing e2e test cases for flag --plain-http
5 participants