Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cms #17

Merged
merged 19 commits into from
Jun 11, 2024
Merged

feat: add cms #17

merged 19 commits into from
Jun 11, 2024

Conversation

JeyJeyGao
Copy link
Contributor

Signed-off-by: Junjie Gao junjiegao@microsoft.com

@JeyJeyGao
feat: ber to der convertor
0ee204b 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: move folders
014888a 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: added go mod
5cbe4bd 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: resolve comments
b871430 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
feat: add cms package
6640c21 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao mentioned this pull request Jan 18, 2024
Closed
Two-Hearts
Two-Hearts reviewed Jan 19, 2024
View reviewed changes
internal/cms/cms.go Outdated Show resolved Hide resolved
internal/cms/signed.go Outdated Show resolved Hide resolved
internal/cms/signed.go Outdated Show resolved Hide resolved
internal/cms/signed.go Outdated Show resolved Hide resolved
internal/cms/signed.go Outdated Show resolved Hide resolved
@Two-Hearts Two-Hearts mentioned this pull request Jan 19, 2024
Merged
@JeyJeyGao
fix: resolve comments
4a6693a 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: typo
b9b912f 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Two-Hearts
Two-Hearts previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as all of my review comments in notaryproject/notation-core-go#181 are resolved.

Two-Hearts
Two-Hearts reviewed Jan 22, 2024
View reviewed changes
internal/cms/errors.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: updated
9ea3d6b 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update gitignore
5061c10 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
Squashed commit of the following:
948d2f5 
commit 2862807
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Wed Jan 31 15:21:55 2024 +0800

    feat: ber to der convertor (notaryproject#11)

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit a373599
Author: Patrick Zheng <patrickzheng@microsoft.com>
Date:   Mon Jan 22 16:37:33 2024 +0800

    ci: add MAKEFILE and build workflow to the repo (notaryproject#19)

    Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

commit 6fa8c7f
Author: Patrick Zheng <patrickzheng@microsoft.com>
Date:   Mon Jan 22 16:36:50 2024 +0800

    ci: add dependabot (notaryproject#16)

    Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

commit bdae447
Author: Patrick Zheng <patrickzheng@microsoft.com>
Date:   Mon Jan 22 16:36:24 2024 +0800

    ci: add code coverage check (notaryproject#15)

    Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

commit 4cc6846
Author: Patrick Zheng <patrickzheng@microsoft.com>
Date:   Mon Jan 22 16:35:54 2024 +0800

    ci: add license checker to the repo (notaryproject#13)

    Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

commit a27c098
Author: Yi Zha <yizha1@microsoft.com>
Date:   Thu Jan 18 10:02:22 2024 +0800

    chore: add CODEOWNERS and MAINTAINERS file (notaryproject#12)

    Resolve notaryproject#2

    Signed-off-by: Yi Zha <yizha1@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
Merge remote-tracking branch 'upstream/main' into feat/cms
2ee2297
priteshbandi
priteshbandi reviewed Feb 2, 2024
View reviewed changes
internal/cms/cms.go Show resolved Hide resolved
internal/cms/cms.go Show resolved Hide resolved
internal/cms/cms.go Outdated Show resolved Hide resolved
internal/oid/algorithm.go Show resolved Hide resolved
internal/cms/signed.go Show resolved Hide resolved
internal/cms/signed.go Show resolved Hide resolved
internal/cms/signed.go Show resolved Hide resolved
internal/cms/signed.go Show resolved Hide resolved
internal/cms/signed.go Show resolved Hide resolved
@JeyJeyGao
fix: update comments
63475e4 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Two-Hearts
Two-Hearts reviewed Mar 21, 2024
View reviewed changes
internal/cms/signed.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: VerifySigner returns valid certificate chain
f64cde3 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update code
df33e7b 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@JeyJeyGao
fix: resolve comment
552850e 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Two-Hearts
Two-Hearts previously approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed May 8, 2024
View reviewed changes
internal/hashutil/hash.go Outdated Show resolved Hide resolved
internal/cms/cms.go Outdated Show resolved Hide resolved
internal/cms/signed.go Show resolved Hide resolved
internal/cms/signed.go Outdated Show resolved Hide resolved
internal/cms/signed.go Show resolved Hide resolved
@JeyJeyGao
fix: added CMS signed data struct version check
c80b2a7 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.53234% with 13 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@2862807). Click here to learn what that means.

❗ Current head a872da4 differs from pull request most recent head 4c93cb4. Consider uploading reports for the commit 4c93cb4 to get more accurate results

Files Patch % Lines
internal/cms/signed.go 91.40% 6 Missing and 5 partials ⚠️
internal/hashutil/hash.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage        ?   95.18%           
=======================================
  Files           ?       10           
  Lines           ?      353           
  Branches        ?        0           
=======================================
  Hits            ?      336           
  Misses          ?        9           
  Partials        ?        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao
fix: update error message
cc96327 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT
shizhMSFT previously approved these changes May 9, 2024
View reviewed changes
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
fix: remove debug log
a872da4 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao dismissed stale reviews from Two-Hearts and shizhMSFT via a872da4 May 10, 2024 08:38
Two-Hearts
Two-Hearts previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes May 14, 2024
View reviewed changes
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
fix: update error message
4c93cb4 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao dismissed stale reviews from shizhMSFT and Two-Hearts via 4c93cb4 May 16, 2024 03:06
priteshbandi
priteshbandi reviewed May 16, 2024
View reviewed changes
internal/cms/signed.go Show resolved Hide resolved
internal/cms/signed.go Show resolved Hide resolved
internal/cms/signed.go Show resolved Hide resolved
Two-Hearts
Two-Hearts approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Jun 11, 2024
View reviewed changes
Copy link

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 53a48a2 into notaryproject:main Jun 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT left review comments

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeyJeyGao @priteshbandi @shizhMSFT @Two-Hearts