Fx icon shown for keywords that are not functions #11311
Comments
|
@EuropeanDeveloper @xomx , we can change the "icon", a simple XPM "file" embedded into the AutoCompletion.cpp source. There currently is no code in AutoCompletion.cpp to check for I'm afraid I don't have the requisite C++ skills to add the check for Alternatively, we could just change the current "fx" image to a simple "block" and have that apply to all since that's what seems offensive. Cheers. |
|
Here's an XPM for this image:
|
|
I understand what was the idea behind "fx" icon. I still think there should be different symbols for functions ( |
|
@EuropeanDeveloper how's this:
NOTE: This creates a whole new problem of updating the autoComplete/*.xml files. Take your example of C - my file looks like this: [...]
<KeyWord name="atan" func="yes">
<Overload retVal="double" >
<Param name="double x" />
</Overload>
</KeyWord>
<KeyWord name="atan2" func="yes">
<Overload retVal="double" >
<Param name="double y" />
<Param name="double x" />
</Overload>
</KeyWord>
<KeyWord name="atan2l" />
<KeyWord name="atanl" />
[...]see how
see Cheers. |
|
I like the proposed solution 🙂. The behavior is expected and correct to my mind. If someone wants to list functions in auto-completion file they should mark them as functions using |
OK - I'll submit a PR - turns out I underestimated my copy/paste coding skills and was able to see a few lines above how to manipulate and analyze the TinyXML object to check for Cheers. |
|
That's great! Thank you 🙂. |
|
Problem:
|
|
@donho for those languages that don't have
I think that looks OK. And then any complaints about "functions not showing with "fx"" can easily be fixed with pull requests to update the autoComplete files rather than changing the N++ AutoCompletion.cpp code. That's my argument for the counterpoint. Understand this is your project and you have the final say. Cheers. |
|
@vinsworldcom: I agree with you. @donho: What about other languages like Batch/CofeeScript/HTML/TypeScript? Their auto-completion files contain mostly keywords. Or some auto-completion files contain preprocessor definitions (e.g. #define). I don't think it makes sense to see "fx" icon for non-functions. The proposed solution by @vinsworldcom will not negatively affect the current implementation I think. If you don't like it, at least change the icon from "fx" to something else. The current icon is really confusing. "fx" implies function, not keywords... |
|
@EuropeanDeveloper there is a bit of a workaround to get a different icon than "fx" that can be triggered after Autocomplete is used once and if you have PythonScript installed. The first time Notepad++ autocomplete is triggered and goes through to show the list, it registers the "fx" image and sets a flag so that it never registers it again. You can override the registration by registering a new image with the same image ID as the "fx" icon, but it will only work after the "fx" image is registered by triggering autocomplete for the first time in a Notepad++ session. If you have PythonScript plugin installed, you can add to your startup script: from Npp import editor, notepad, MENUCOMMAND
notepad.menuCommand(MENUCOMMAND.LANG_PERL)
editor.beginUndoAction()
editor.setText('pr')
editor.gotoPos(2)
notepad.menuCommand(MENUCOMMAND.EDIT_AUTOCOMPLETE)
editor.autoCCancel()
editor.endUndoAction()
editor.undo()
notepad.menuCommand(MENUCOMMAND.LANG_TEXT)
xpmbox = """/* XPM */
"16 16 70 1 ",
" c None",
". c #712472",
"X c #752775",
"o c #7A2B7B",
"O c #7C2D7D",
"+ c #7C2E7C",
"@ c #7E2E7E",
"# c #7E307F",
"$ c #7F3080",
"% c #8D358E",
"& c #953896",
"* c #9C3C9D",
"= c #9F3C9F",
"- c #8E468F",
"; c #904E91",
": c #965297",
"> c #A74FA8",
", c #A650A7",
"< c #A850A9",
"1 c #A950AA",
"2 c #A952AA",
"3 c #BB6FBC",
"4 c #BC70BD",
"5 c #CB67CC",
"6 c #D16AD2",
"7 c #D26BD3",
"8 c #D16DD2",
"9 c #D36ED4",
"0 c #D56FD5",
"q c #8A99AE",
"w c #98A4AE",
"e c #9CA7AE",
"r c #ACB5AD",
"t c #ACB4AE",
"y c #B5BBAD",
"u c #C1C4AC",
"i c #CCCEAC",
"p c #D5D5AC",
"a c #E5E2AB",
"s c #E9E5AB",
"d c #F7F0AB",
"f c #CF88CF",
"g c #DD98DE",
"h c #E698E7",
"j c #E990EA",
"k c #EB91EC",
"l c #EE9DEF",
"z c #FA98FB",
"x c #FA99FB",
"c c #FA9BFB",
"v c #FA9FFB",
"b c #E3ACE3",
"n c #E2AFE2",
"m c #EEA5EF",
"M c #EEBEEE",
"N c #FAABFB",
"B c #FAAEFB",
"V c #E4CAE4",
"C c #E6CCE6",
"Z c #E8D1E8",
"A c #EBD1EB",
"S c #ECD2EC",
"D c #EDD8ED",
"F c #F0D4F0",
"G c #F0D5F0",
"H c #F2DBF2",
"J c #F0E3F0",
"K c #F2E0F3",
"L c #F3E3F3",
"P c #F4E6F4",
" ",
" ",
" HfJ ",
" HfbfL ",
" FfMBkfJ ",
" dptq fnNzzjfP ",
" ,3mxxzh; ",
"dsputw ,83mvl:@ ",
" <604g-*@ ",
" daiyw C179$=%O ",
" Z15@&OG ",
" D1@XZ ",
" S.C ",
" ",
" ",
" "
"""
editor.registerImage(1000, xpmbox)That basically sets language to Perl, types some characters, triggers autocomplete (so the "fx" image is registered) undoes the typing, sets language back to normal text (as if nothing happened) and then registers the new proposed box image with the same image ID (effectively overwriting the "fx" image for all subsequent autocompletes). Unfortunately, this still only allows 1 icon for all completes from the "autoComplete/*.xml" files. I think the Still hoping @donho reconsiders this issue / PR. Cheers. |
|
If the keyword is not function (fx), then it"s normal keyword (kw). |
|
@donho: Can't we use the box icon for keywords as @vinsworldcom proposed? |
|
@donho not sure the "kw" icon will work that well. Not using a fixed-width font to achieve some form of likeness with the current "fx" icon causes an issue since the "w" character is rather wide. This makes the icon wider than tall yet it must fit to 16, 16, so the height has to shrink. This is what it looks like - and I personally don't think it looks good and is a bit confusing:
The PNG file from which the XPM was generated: I still think the "box" icon works well as it and "fx" are both "components" of the Notepad++ function list and we're talking about "Function" completion.
Cheers. |
|
@vinsworldcom @EuropeanDeveloper The icon fx was added for the purpose of distinguishing the languages keyword entries from the word entries. So it's enough IMO that 1 icon for both kinds of keywords. But if we want to add one more icon for telling "normal keyword" from "function keyword", I prefer to have the same colour & style, for the following reasons:
After all, you can suggest the other symbols to stand for "normal keyword" with the constraint. It will be accepted if it's meaningful and readable. |
|
@donho understood. With regards to point 1 - can we look forward to a Scintilla 5+ upgrade soon? :-) The XPM image format Scintilla specifies can include a color "None" for transparency, and I use that for the none "fx", "box", "kw", etc.. parts of the XPMs I create so hopefully that will "translate" well as Scintilla release 5.0.1 allows " dropping the "w" from "kw" and just using a script "k" seems to work a little better. Visually, it's hardly differentiated due to point 2 above:
PNG image: XPM: I can submit a new PR with the updated image if we can agree on one here. Cheers |
Yes, once v8.3.x is stable enough. I think next release v8.3.3 will be stable, so I will work on the Scintilla 5+ updating.
This |
|
I agree that "k" icon looks like "f", it is quite hard to distinguish them. If we want to use the same icon for "normal" keywords and functions, I think the best approach is to use box icon. What do you think about this? |
@donho @EuropeanDeveloper , maybe I was being to literal on 2 and 3 with "style" using a letter. How about an icon - like the box, but not purple colored. How about a black key for "keyword":
Same "style/color" base black with transparent (color = None) background and yet much more easily distinguished. PNG: XPM: Cheers. |
|
How about a cube like it? |
|
@donho @EuropeanDeveloper how about:
I like it. PNG: XPM: Cheers. |
|
@vinsworldcom And also please post one more screenshot under another language without distinguishing normal / function keywords (like Java), so we have a vision more general, not only in c/c++ |
|
@donho @EuropeanDeveloper - no worries - I'm happy this may actually make it in! Language of "new-1" set to "Perl": Language of "new-1" set to "Javascript": PNG: XPM: If we can agree on a solution, I'll resubmit a pull request with the appropriate XPM images and code changes. Cheers. |
|
@vinsworldcom |
|
I love it! Good job @vinsworldcom 👍. |
|
@donho should I open a new pull request, or just push to the existing "rejected" pull request and you can re-accept it if you still want to go this way? Happy to do either. Cheers. |
|
OK for pushing to the existing "rejected" pull request |
Description of the Issue
After the implementation of #11087, "fx" icon is shown for all keywords from auto-completion file. The icon should be shown only for keywords with attribute
func="yes".Steps to Reproduce the Issue
C.ab.Expected Behavior
"fx" icon is shown only for functions (
abort,abs,access,acos), not for keywords (absread,abswrite,acosl,allocmem,arc).Actual Behavior
"fx" icon is shown for all keywords (including ones that are not functions) from auto-completion file.
Debug Information
Notepad++ v8.3.2 (64-bit)
Build time : Feb 27 2022 - 03:35:46
Path : C:\Program Files\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 2009
OS Build : 19042.1526
Current ANSI codepage : 1250
Plugins : DSpellCheck.dll mimeTools.dll NppConverter.dll NppExport.dll XMLTools.dll
The text was updated successfully, but these errors were encountered: