Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete icons for func=yes and others #11314

Closed

Conversation

vinsworldcom
Copy link

Fix #11311

When using the new "fx" icon in autocomplete for "autoComplete/*.xml" files, there is a desire to distinguish between actual "functions" - those that have the XML parameter func="yes" set and those that don't.

This PR adds another XPM image taken from the Notepad++ function list (the icon for a function name - a light purple box) and uses that for non-function entries in the "autoComplete/*.xml" files. We add the new XPM, register it with the other one and then in the routine where we add the "\x1E IMG_ID", we just test if the XML node has the func parameter set to yes. If so, use the "fx" icon, if not, use the new box one.

Examples are shown in the referenced issue.

Cheers.

@donho donho self-assigned this Mar 2, 2022
@donho donho added the reject label Mar 2, 2022
@donho
Copy link
Member

donho commented Mar 2, 2022

As I mentioned in #11311, fx for distinguishing from word entries.
This PR will make more complain for the API files without func attribute at all, then we will run after the problem by adding the icons over and over again.
I prefer to keep the concept as simple as possible. Sorry that I have reject this PR.

@donho donho closed this Mar 2, 2022
@vinsworldcom
Copy link
Author

@donho understand about simplicity, my argument for the counterpoint is in the issue. Understood if you ultimately choose to reject this - no worries.

Cheers.

@donho donho reopened this Mar 10, 2022
@donho donho removed the reject label Mar 10, 2022
@donho donho closed this in 9a1a999 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fx icon shown for keywords that are not functions
2 participants