Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Editor OK button should be disabled if Text-to-Insert is empty #13315

Closed
alankilborn opened this issue Mar 8, 2023 · 2 comments
Closed

Comments

@alankilborn
Copy link
Contributor

Description of the Issue

See StR.

Steps to Reproduce (StR) the Issue

  1. Invoke Column Editor
  2. Click the Text to Insert radio button
  3. Delete all text out of the edit box below the Text to Insert radio button

Expected Behavior

I expected the OK button to turn be disabled/grey when the last character is removed from the edit box.

Actual Behavior

OK button remains enabled:
image

Debug Information

Notepad++ v8.5 (64-bit)
Build time : Mar 6 2023 - 02:18:13
Path : W:\npp.misc_NoBackup\Releases\npp.8.5\npp.8.5.portable.x64\notepad++.exe
Command Line : -titleAdd="8.5 64-bit" -multiInst
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 21H2
OS Build : 19044.2486
Current ANSI codepage : 1252
Plugins :
mimeTools (2.9)
NppConverter (4.5)
NppExport (0.4)
PythonScript (2)

@Yaron10
Copy link

Yaron10 commented Mar 8, 2023

If the column-selection is not zero-width, it should be legit (like replacing X with an empty string).

If you're not in column-selection, pressing OK should not modify the file.
But it does: Undo is active, and you get Changed History markers.
Do you understand why?

@alankilborn
Copy link
Contributor Author

If the column-selection is not zero-width, it should be legit (like replacing X with an empty string).

Nah, too obscure. Just press Delete key, don't even invoke Column Editor at all.

If you're not in column-selection, pressing OK should not modify the file.
Do you understand why?

Nope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants