Column Editor OK button should be disabled if Text-to-Insert is empty #13444
Conversation
| if (toText) | ||
| { | ||
| ColumnEditorParam colEditParam = NppParameters::getInstance()._columnEditParam; | ||
| if (!colEditParam._insertedTextContent.empty()) |
There was a problem hiding this comment.
It'll be more straight forward to get text from the text field control.
| ColumnEditorParam colEditParam = NppParameters::getInstance()._columnEditParam; | ||
| if (!colEditParam._insertedTextContent.empty()) | ||
| { | ||
| ::SetDlgItemText(_hSelf, IDC_COL_TEXT_EDIT, colEditParam._insertedTextContent.c_str()); |
There was a problem hiding this comment.
Why do we need this line?
Or there's another bug?
| } | ||
| else | ||
| { | ||
| ::EnableWindow(::GetDlgItem(_hSelf, IDOK), true); |
There was a problem hiding this comment.
EnableWindow(::GetDlgItem(_hSelf, IDOK), xxx);
should be call only once at the end - xxx is the result of IDC_COL_TEXT_EDIT (empty or not).
|
I simplified the change based on your comments. |
| if (toText) | ||
| { | ||
| const int stringSize = 1024; | ||
| TCHAR str[stringSize]; |
There was a problem hiding this comment.
const int stringSize = 1024; can be replaced with constexpr int stringSize = 1024;
Add initializer to be sure e.g. TCHAR str[stringSize]{};
There was a problem hiding this comment.
@ozone10
good remark.
Could you add the "best practice" in contribution coding style:
https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/CONTRIBUTING.md#coding-style
Or create a issue for the "best practice" so I can add them in the guideline?
|
Life is complicated already, let's make our code simpler. |
Fix #13315