Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Configurator / Themes: Perl styles need updating #14192

Closed
pryrt opened this issue Sep 28, 2023 · 0 comments
Closed

Style Configurator / Themes: Perl styles need updating #14192

pryrt opened this issue Sep 28, 2023 · 0 comments

Comments

@pryrt
Copy link
Contributor

pryrt commented Sep 28, 2023

Description of the Issue

Scintilla/Lexilla's LexPerl has changed significantly since the stylers.model.xml list of styles for Perl was created/last-updated, so it is now out-of-date, and Notepad++ isn't settings colors for all the styles that are available in LexPerl.

  • stylers.model.xml defines three styles (PREPROCESSOR, PUNCTUATION, LONGQUOTE) that aren't used by LexPerl.
  • stylers.model.xml is missing 24 styles that are used by LexPerl.
  • Some of the names for the styles should be updated for clarity.

I will be submitting a PR that includes the updates to the style list for both stylers.model.xml and themes\DarkModeDefault.xml, with colors that are reasonable for those default themes.

For the other themes that ship with Notepad++, I was thinking of setting colorStyle="0" for the new styles, so that they will inherit the foreground and background from their theme, to avoid defining colors that clash with the theme (it will mean that users who use those themes will not notice any changes in syntax highlighting, but if they go to Style Configurator, they will see more Styles available to Perl). But if someone disagrees and thinks I should leave the other themes alone, I won't bother.

@pryrt pryrt mentioned this issue Sep 28, 2023
@donho donho closed this as completed in d33e297 Oct 5, 2023
donho pushed a commit to donho/notepad-plus-plus that referenced this issue Oct 20, 2023
- update `stylers.model.xml` to have the 41 styles supported by LexPerl
- update `themes\DarkModeDefault.xml` to have the 41 styles supported by LexPerl

Fix  notepad-plus-plus#14192, close notepad-plus-plus#14193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant