You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Scintilla/Lexilla's LexPerl has changed significantly since the stylers.model.xml list of styles for Perl was created/last-updated, so it is now out-of-date, and Notepad++ isn't settings colors for all the styles that are available in LexPerl.
stylers.model.xml defines three styles (PREPROCESSOR, PUNCTUATION, LONGQUOTE) that aren't used by LexPerl.
stylers.model.xml is missing 24 styles that are used by LexPerl.
Some of the names for the styles should be updated for clarity.
I will be submitting a PR that includes the updates to the style list for both stylers.model.xml and themes\DarkModeDefault.xml, with colors that are reasonable for those default themes.
For the other themes that ship with Notepad++, I was thinking of setting colorStyle="0" for the new styles, so that they will inherit the foreground and background from their theme, to avoid defining colors that clash with the theme (it will mean that users who use those themes will not notice any changes in syntax highlighting, but if they go to Style Configurator, they will see more Styles available to Perl). But if someone disagrees and thinks I should leave the other themes alone, I won't bother.
The text was updated successfully, but these errors were encountered:
- update `stylers.model.xml` to have the 41 styles supported by LexPerl
- update `themes\DarkModeDefault.xml` to have the 41 styles supported by LexPerl
Fixnotepad-plus-plus#14192, closenotepad-plus-plus#14193
Description of the Issue
Scintilla/Lexilla's LexPerl has changed significantly since the
stylers.model.xml
list of styles for Perl was created/last-updated, so it is now out-of-date, and Notepad++ isn't settings colors for all the styles that are available in LexPerl.stylers.model.xml
defines three styles (PREPROCESSOR, PUNCTUATION, LONGQUOTE) that aren't used by LexPerl.stylers.model.xml
is missing 24 styles that are used by LexPerl.I will be submitting a PR that includes the updates to the style list for both
stylers.model.xml
andthemes\DarkModeDefault.xml
, with colors that are reasonable for those default themes.For the other themes that ship with Notepad++, I was thinking of setting
colorStyle="0"
for the new styles, so that they will inherit the foreground and background from their theme, to avoid defining colors that clash with the theme (it will mean that users who use those themes will not notice any changes in syntax highlighting, but if they go to Style Configurator, they will see more Styles available to Perl). But if someone disagrees and thinks I should leave the other themes alone, I won't bother.The text was updated successfully, but these errors were encountered: