Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding FlushFileBuffers-fail user notification #14842

Closed
wants to merge 2 commits into from
Closed

adding FlushFileBuffers-fail user notification #14842

wants to merge 2 commits into from

Conversation

xomx
Copy link
Contributor

@xomx xomx commented Mar 8, 2024

Helps in fixing the #6133 .

With this PR the affected users will be at least alerted that something bad is happening.

Simulated case message:
npp-ffb-fail-notification-smaller

@xomx
Copy link
Contributor Author

xomx commented Mar 8, 2024

@donho
During testing, I discovered the possibility that under certain conditions the N++ can crash (and thus possibly cause some disk corruptions - but this I have not proven yet) when using snapshot backups. It is all about the ability to recursively (ab)use the N++ backup-mutex. I will investigate and let you know.

@donho donho self-assigned this Mar 8, 2024
donho
donho requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@donho donho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider to merge the 2 treatments into one block.

PowerEditor/src/MISC/Common/FileInterface.cpp Outdated Show resolved Hide resolved
@donho donho added enhancement Proposed enhancements of existing features accepted labels Mar 9, 2024
@donho donho closed this in 4e1a3ee Mar 9, 2024
@xomx xomx deleted the FlushFileBuffers-fail-notification branch March 11, 2024 09:19
@xomx xomx mentioned this pull request Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donho donho donho approved these changes

Assignees

@donho donho

Labels
accepted enhancement Proposed enhancements of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xomx @donho