Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding FlushFileBuffers-fail user notification #14842

Closed
wants to merge 2 commits into from
Closed

adding FlushFileBuffers-fail user notification #14842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cee0fd6
adding FlushFileBuffers-fail user notification
xomx Mar 8, 2024
fad0303
explanation and optimalization
xomx Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 40 additions & 3 deletions PowerEditor/src/MISC/Common/FileInterface.cpp
View file
Open in desktop
Expand Up @@ -92,26 +92,63 @@ void Win32_IO_File::close()
{
if (isOpened())
{
NppParameters& nppParam = NppParameters::getInstance();

DWORD flushError = NOERROR;
if (_written)
{
if (!::FlushFileBuffers(_hFile))
{
flushError = ::GetLastError();

if (!nppParam.isEndSessionCritical())
{
// because of there is not an externally forced shutdown/restart of Windows in progress,
// we can at least alert the user that the file data could not actually be saved

std::wstring curFilePath;
const DWORD cchPathBuf = MAX_PATH + 128;
WCHAR pathbuf[cchPathBuf]{};
// the dwFlags used below are the most error-proof and informative
DWORD dwRet = ::GetFinalPathNameByHandle(_hFile, pathbuf, cchPathBuf, FILE_NAME_OPENED | VOLUME_NAME_NT);
if ((dwRet == 0) || (dwRet >= cchPathBuf))
{
// probably insufficient path-buffer length, the classic style must suffice
std::wstring_convert<std::codecvt_utf8_utf16<wchar_t>> converter;
curFilePath = converter.from_bytes(_path);
}
else
{
// ok
// - the chosen file path style here will allow us to also see the MS MUP (multiple UNC provider) style path
// for a possible network drive mapped here as the usual disk-letter, e.g.:
// "\Device\Mup\NETWORK_SERVER_DNS_NAME_OR_IP\SERVER_PATH\FILENAME"
// "\Device\Mup\NETWORK_SERVER_DNS_NAME_OR_IP@SSL@PORT_NUMBER\DavWWWRoot\SERVER_PATH\FILENAME"
// - classic local disk will be visible here like: "\Device\HarddiskVolume2\ABSOLUTE_PATH_WITHOUT_DRIVENAME\FILENAME"
curFilePath = pathbuf;
}

std::wstring errMsg = L"Notepad++ has encountered a serious system problem while saving:\n\n";
errMsg += curFilePath;
errMsg += L"\n\nThat file, temporarily stored in the system cache, cannot be finally committed to the storage device selected! \
This is probably a storage driver or hardware issue, beyond the control of the Notepad++. \
Please try using another storage and also check if your saved data is not corrupted.\n\nError Code reported: ";
errMsg += std::to_wstring(flushError) + L" - " + GetLastErrorAsString(flushError);
::MessageBoxW(NULL, errMsg.c_str(), L"WARNING - filebuffer flushing fail!", MB_OK | MB_ICONWARNING | MB_SYSTEMMODAL);
}
}
}
::CloseHandle(_hFile);

_hFile = INVALID_HANDLE_VALUE;


NppParameters& nppParam = NppParameters::getInstance();
if (nppParam.isEndSessionStarted() && nppParam.doNppLogNulContentCorruptionIssue())
{
generic_string issueFn = nppLogNulContentCorruptionIssue;
issueFn += TEXT(".log");
generic_string nppIssueLog = nppParam.getUserPath();
pathAppend(nppIssueLog, issueFn);


std::string msg;
if (flushError != NOERROR)
{
Expand Down