Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update english and french translations #2299

Closed
wants to merge 1 commit into from

Conversation

cmeriaux
Copy link
Contributor

update english and french translations without any Tab/space replacement
Fixed #2293

@donho
Copy link
Member

donho commented Sep 18, 2016

As my comment in the previous PR: "Go to next" and "Recherche le... suivant" is not necessary at all. Therefore this PR won't be accepted.

@donho donho closed this Sep 18, 2016
@cmeriaux
Copy link
Contributor Author

@donho I got your point. Menus are clear and "Recherche le suivant" is not necessary. You are right.
My point is : "Recherche le suivant" is mandatory in the Shortcut Mapper. As my screenshot shows, it's very confusing
bugtranslation

More generally, a translationcan't rely on a sub-menu translation or you'll have a problem in the shortcut mapper.

So can you consider my point of view and reopen the ticket ?
Thanks

@donho
Copy link
Member

donho commented Sep 19, 2016

@cmeriaux I see your point, but my choice remines the same.

@cmeriaux
Copy link
Contributor Author

@donho so you are OK that I add in shortcutMapper.cpp some check to prepend the submenu ID to the translate ID ?

@donho
Copy link
Member

donho commented Sep 19, 2016

@cmeriaux I don't think it's a good idea. The coding effort (and the side effect of making maintenance harder) is necessary (to me) in the case of more important issue.
I would keep the items display as it is.

@cmeriaux
Copy link
Contributor Author

@donho
You don't want to complicate the "shortcut mapper" code.
You don't want redundant translation with a sub-menu translation.
So you don't care that Shortcut Mapper" GUI prompt an incomprehensible message.

There are some contradiction in what you says and what is implemented. Sometime you repeat the sub-menu message, some time you don't

"mark all"/"Using 1st style"
"mark all"/"Using 2st style"
"unmark all"/"clear 1st style"
"unmark all"/"clear 2st style"
"jump up"/"1st style"
"jump up"/"2st style"
"jump down"/"1st style"
"jump down"/"2st style"
"EOL Conversion"/"convert ...."
"close more"/"close but ...."
"project"/"project pannel ....3

I suggest you to make every body happy ( user of the GUI, user of the Shortcut Mapper, Developer of Shortcut mapper) :
write a translation that doesn't rely on a sub-menu message

So please accept my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants