Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unicode Problem. Issue Name 'On Debug Build, Korean Input has As… #4530

Closed
wants to merge 3 commits into from
Closed

Fix Unicode Problem. Issue Name 'On Debug Build, Korean Input has As… #4530

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a6fdee
Fix Unicode Problem. Issue Name 'On Debug Build, Korean Input has As…
ffdd270 May 26, 2018
1ee6362
Remove Unicode compiler encounters.
ffdd270 May 26, 2018
2a957ab
generic _ string is TCHAR, so it was replaced with a more suitable is…
ffdd270 Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion PowerEditor/src/ScitillaComponent/AutoCompletion.cpp
View file
Open in desktop
Expand Up @@ -43,7 +43,7 @@ static bool isInList(generic_string word, const vector<generic_string> & wordArr

static bool isAllDigits(const generic_string &str)
{
return std::all_of(str.begin(), str.end(), ::isdigit);
return std::all_of(str.begin(), str.end(), ::iswdigit);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_istdigit if you want to care about both. Since generic_string is typedef'd, I'd advice using a TCHAR version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for Code Review. I will fix that on next commit.

but I have one question, generic_string is templated string? For Example. std::wstring same as generic_string?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. From Common.h:

typedef std::basic_string<TCHAR> generic_string;
typedef std::basic_stringstream<TCHAR> generic_stringstream;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You For Answer. I fix that.

}


Expand Down