Fix Unicode Problem. Issue Name 'On Debug Build, Korean Input has As… #4530
Conversation
…ert.' When compiled in a Unicode environment, the isAllDigits function uses the iswdigit function. Other environments use the isdigigit function.
| @@ -43,7 +43,11 @@ static bool isInList(generic_string word, const vector<generic_string> & wordArr | |||
|
|
|||
| static bool isAllDigits(const generic_string &str) | |||
| { | |||
| #ifdef _UNICODE | |||
There was a problem hiding this comment.
Notepad++ is Unicode. ANSI version was dropped long back. Moreover, generic_string is typedef std::basic_string<TCHAR> generic_string; where TCHAR is WCHAR because of Unicode project setting. Also refer discussion - #3198 (comment)
There was a problem hiding this comment.
Then, Can I erase the compiler encounters without considering ASCII situations? And was there an issue in the context of using iswdigit?
There was a problem hiding this comment.
Notepad++ is Unicode. ANSI version was dropped long back. Moreover,
generic_stringistypedef std::basic_string<TCHAR> generic_string;whereTCHARisWCHARbecause of Unicode project setting. Also refer discussion - #3198 (comment)
Then why not replace all references of T in the entire project with W. Add some static_assert or #define all T-names to something that would cause a compiler error, and preventing T-uses.
| @@ -43,11 +43,7 @@ static bool isInList(generic_string word, const vector<generic_string> & wordArr | |||
|
|
|||
| static bool isAllDigits(const generic_string &str) | |||
| { | |||
| #ifdef _UNICODE | |||
| return std::all_of(str.begin(), str.end(), ::iswdigit); | |||
There was a problem hiding this comment.
_istdigit if you want to care about both. Since generic_string is typedef'd, I'd advice using a TCHAR version.
There was a problem hiding this comment.
Thank you for Code Review. I will fix that on next commit.
but I have one question, generic_string is templated string? For Example. std::wstring same as generic_string?
There was a problem hiding this comment.
Yep. From Common.h:
typedef std::basic_string<TCHAR> generic_string;
typedef std::basic_stringstream<TCHAR> generic_stringstream;There was a problem hiding this comment.
Thank You For Answer. I fix that.
|
There a some further code areas which use:
instead of
on generic_string, e.g. and maybe also the scintilla component need to be checked. |
Perhaps - but what's the convention on making changes inside scintilla? It's not exactly clear right now. |
|
Scintilla (except lexers, which mostly maintained by external developers) doesn't directly call ctype functions. https://sourceforge.net/p/scintilla/code/ci/348e55f8107caddf4f48b8c514caa90f1c886c48/ |
Fix debug mode assert in `AutoCompletion::isAllDigits` methode while inputting non ASCII characters. Fix #5280
When compiled in a Unicode environment, the isAllDigits function uses the iswdigit function.
Other environments use the isdigit function.
Fix Issue #4529.