Fix typo and improved algo for isAllDigits #5828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAPJe71
reviewed
Jun 25, 2019
|
|
||
| bool isDigit = ::isdigit(int(i)) != 0; | ||
| if (!isDigit) | ||
| if (i < 48 || i > 57) |
There was a problem hiding this comment.
Would this still work when str is a wide string?
Notepad++ is build with UNICODE enabled thus generic_string will be a wide string.
|
That code is not readable, what's wrong with not using '0' and '9'? |
kspalaiologos
pushed a commit
to kspalaiologos/notepad-plus-plus
that referenced
this pull request
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained 344850a#r33867431 I was trying to correct the typo.
Then I realized, as we are checking each character one by one, then do we really need to call
::isdigit? So instead of calling::isdigitwhy don't we check ASCII value for 0~9 and return result accordingly.P.S. Still I favor PR #4530.