Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase untruncated Find-result window line length to 2048 #9030

Conversation

sasumner
Copy link
Contributor

Fixes #7723

@chcg chcg added the enhancement Proposed enhancements of existing features label Oct 19, 2020
@donho donho self-assigned this Oct 21, 2020
@donho
Copy link
Member

donho commented Oct 21, 2020

@sasumner I suppose you have check if it works and there's no regression?

@sasumner
Copy link
Contributor Author

@donho said:

I suppose you have check if it works and there's no regression?

Well, I test all of my PRs. :-)
I ran a few simple tests on this one, seemed to work.
I did not exhaustively test it as it is "only" a length change.
A recent PR changed hardcoded occurrences 1024 (the old value for this) to use the #define name, so that doesn't seem to be a concern.
Do you have some other concerns?
If so, can you be specific?
I am willing to run more tests, I'm just not sure what they should be.

@donho
Copy link
Member

donho commented Oct 21, 2020

Do you have some other concerns?
If so, can you be specific?

No no, I'm just lazy :)

I am willing to run more tests, I'm just not sure what they should be.

I guess it's enough to test 1 or 2 case(s) to make sure it's working, and 1 or 2 usual case(s) to ensure there's no regression.

@donho donho added the accepted label Oct 21, 2020
@donho donho closed this in 4830b77 Oct 21, 2020
@sasumner
Copy link
Contributor Author

BTW, for the testing I did do, I concentrated on lines with A-z0-9 data and line lengths slightly less than the new threshold (to NOT see the ...) and lines lengths slightly more than the threshold (to definitely see the ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted enhancement Proposed enhancements of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOUBLE (edit: was REMOVE) the line-length limit in Find-result window
3 participants