Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up DirectWrite mention on in RTL text section #668

Closed
mkupper opened this issue May 3, 2024 · 0 comments · Fixed by #669
Closed

Clean up DirectWrite mention on in RTL text section #668

mkupper opened this issue May 3, 2024 · 0 comments · Fixed by #669

Comments

@mkupper
Copy link

mkupper commented May 3, 2024

https://npp-user-manual.org/docs/views/#text-direction has two minor issues

  1. The phrase "Use Direct Write option" should be "Use DirectWrite option".
  2. The current text also is "and if you have that option checkmarked" which should be "and if that option is checkmarked".

The reasoning for the second change is that DirectWrite is enabled by default for new installations since npp v8.6. Thus it may well be enabled for some people even though they did not set the option and to use RTL support they will need to turn it off.

There's also an issue on the https://npp-user-manual.org/docs/preferences/ which still has "This is not on by default, because it may cause performance issues." I have started a npp forum thread about that topic.
pryrt added a commit to pryrt/npp-usermanual that referenced this issue May 3, 2024
@pryrt
DirectWrite Imrovements
7b2e23d 
- Fix "Direct Write" -> "DirectWrite"
- Indicate that before v8.6, "off" was default; but v6.8 and newer, "on" is default
- Reword performance warning
closes notepad-plus-plus#668
@pryrt pryrt mentioned this issue May 3, 2024
Merged
pryrt added a commit that referenced this issue May 5, 2024
@pryrt
DirectWrite Imrovements
ad615b2 
- Fix "Direct Write" -> "DirectWrite"
- Indicate that before v8.6, "off" was default; but v6.8 and newer, "on" is default
- Reword performance warning
closes #668
@pryrt pryrt closed this as completed in #669 May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DirectWrite Improvements pryrt/npp-usermanual
1 participant
@mkupper