DirectWrite Improvements #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pryrt
commented
May 3, 2024
pryrt
commented
- Fix "Direct Write" -> "DirectWrite"
- Indicate that before v8.6, "off" was default; but v6.8 and newer, "on" is default
- Reword performance warning closes Clean up DirectWrite mention on in RTL text section #668
- Fix "Direct Write" -> "DirectWrite" - Indicate that before v8.6, "off" was default; but v6.8 and newer, "on" is default - Reword performance warning closes notepad-plus-plus#668
|
I would change the first sentence to
I think that is a bit clearer. |
|
I would go a bit further with it, perhaps:
|
- Rephrased the old-vs-new behavior bullet point - Add a note near the top of the Preferences page that indicates what "default setting" means throughout the document
|
@molsonkiko , @alankilborn , do my updates look sufficient? |
|
I approve. It's as clear and concise as could be reasonably expected IMO
…On Sat, May 4, 2024, 2:42 PM PeterCJ ***@***.***> wrote:
@molsonkiko <https://github.com/molsonkiko> , @alankilborn
<https://github.com/alankilborn> , do my updates look sufficient?
—
Reply to this email directly, view it on GitHub
<#669 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALAQAI7BPYGFY7U6PFSCXVDZAVI2VAVCNFSM6AAAAABHGFHZQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGQYDMMZZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Yep, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.