fix: copy parameters in asyncSendMessageWithResult* to avoid crashes,…

… see #703
notepadqq · Aug 20, 2019 · 2f54099 · 2f54099
1 parent 45f90b6
commit 2f54099
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/ui/EditorNS/editor.cpp b/src/ui/EditorNS/editor.cpp
@@ -419,7 +419,7 @@ namespace EditorNS
 
     unsigned int messageIdentifier = 0;
 
-    QPromise<QVariant> Editor::asyncSendMessageWithResultP(const QString &msg, const QVariant &data)
+    QPromise<QVariant> Editor::asyncSendMessageWithResultP(const QString msg, const QVariant data)
     {
         unsigned int currentMsgIdentifier = ++messageIdentifier;
 
@@ -463,12 +463,12 @@ namespace EditorNS
         return resultPromise;
     }
 
-    QPromise<QVariant> Editor::asyncSendMessageWithResultP(const QString &msg)
+    QPromise<QVariant> Editor::asyncSendMessageWithResultP(const QString msg)
     {
         return this->asyncSendMessageWithResultP(msg, 0);
     }
 
-    std::shared_future<QVariant> Editor::asyncSendMessageWithResult(const QString &msg, const QVariant &data, std::function<void(QVariant)> callback)
+    std::shared_future<QVariant> Editor::asyncSendMessageWithResult(const QString msg, const QVariant data, std::function<void(QVariant)> callback)
     {
         unsigned int currentMsgIdentifier = ++messageIdentifier;
 
@@ -495,7 +495,7 @@ namespace EditorNS
         return fut;
     }
 
-    std::shared_future<QVariant> Editor::asyncSendMessageWithResult(const QString &msg, std::function<void(QVariant)> callback)
+    std::shared_future<QVariant> Editor::asyncSendMessageWithResult(const QString msg, std::function<void(QVariant)> callback)
     {
         return this->asyncSendMessageWithResult(msg, 0, callback);
     }

diff --git a/src/ui/include/EditorNS/editor.h b/src/ui/include/EditorNS/editor.h
@@ -392,11 +392,11 @@ namespace EditorNS
          *                 If set, you should NOT use the return value of this method.
          * @return
          */
-        QPromise<QVariant> asyncSendMessageWithResultP(const QString &msg, const QVariant &data);
-        QPromise<QVariant> asyncSendMessageWithResultP(const QString &msg);
+        QPromise<QVariant> asyncSendMessageWithResultP(const QString msg, const QVariant data);
+        QPromise<QVariant> asyncSendMessageWithResultP(const QString msg);
 
-        std::shared_future<QVariant> asyncSendMessageWithResult(const QString &msg, const QVariant &data, std::function<void(QVariant)> callback = 0);
-        std::shared_future<QVariant> asyncSendMessageWithResult(const QString &msg, std::function<void(QVariant)> callback = 0);
+        std::shared_future<QVariant> asyncSendMessageWithResult(const QString msg, const QVariant data, std::function<void(QVariant)> callback = 0);
+        std::shared_future<QVariant> asyncSendMessageWithResult(const QString msg, std::function<void(QVariant)> callback = 0);
 
         /**
          * @brief Print the editor. As of Qt 5.11, it produces low-quality, non-vector graphics with big dimension.