stb_truetype: Add missing return keyword
#1422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NBickford-NV
added a commit
to NBickford-NV/imgui
that referenced
this pull request
Dec 19, 2022
…_cid_get_glyph_subrs` (duplicate of nothings/stb#1422) Signed-off-by: Neil Bickford <nbickford@nvidia.com>
ocornut
pushed a commit
to ocornut/imgui
that referenced
this pull request
Dec 20, 2022
…_cid_get_glyph_subrs` (#6007) Submitted as PR: nothings/stb#1422 Signed-off-by: Neil Bickford <nbickford@nvidia.com>
Signed-off-by: Neil Bickford <nbickford@nvidia.com>
NBickford-NV
force-pushed
the
neilbickford/truetype-return
branch
from
bf5019d
to
508d7a6
Compare
kjblanchard
pushed a commit
to kjblanchard/imgui
that referenced
this pull request
May 5, 2023
…_cid_get_glyph_subrs` (ocornut#6007) Submitted as PR: nothings/stb#1422 Signed-off-by: Neil Bickford <nbickford@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi stb maintainers! Here's one more pull request: in stb_truetype.h,
stbtt__cid_get_glyph_subrs()creates a nullstbtt__bufon an invalid format or glyph as if to return an error, but discards the result. This pull request adds the keyword to return it.Thanks!