Paragraph text can now explicitly be spanned #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background: Consumers of the library may for instance want line spacing for the paragraph text but TextView's `lineSpacingMultiplier` and/or `lineSpacingExtra` apply line spacing to all lines. With this change, paragraphs may explicitly be spanned with a paragraph affecting span such as `LineHeightSpan` while the other tags (e.g. headings) will be unaffected.
|
Looks good! 👍 |
Merged
noties
added a commit
that referenced
this pull request
Aug 18, 2018
* Fix OrderedListItemSpan text position (baseline) (#55) * Add softBreakAddsNewLine option for SpannableConfiguration (#54) * Paragraph text can now explicitly be spanned (#58) Thanks to @c-b-h! * Fix table border color if odd background is specified (#56) * Add table customizations (even and header rows)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Consumers of the library may for instance want line spacing for the
paragraph text but TextView's
lineSpacingMultiplierand/orlineSpacingExtraapply line spacing to all lines.With this change, paragraphs may explicitly be spanned with a paragraph
affecting span such as
LineHeightSpanwhile the other tags(e.g. headings) may be kept unaffected.