Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tableOddRowBackgroundColor changes all table colors below the first odd row #56

Closed
carlosefonseca opened this issue Aug 6, 2018 · 3 comments
Closed

tableOddRowBackgroundColor changes all table colors below the first odd row #56

carlosefonseca opened this issue Aug 6, 2018 · 3 comments
Labels
bug
Milestone
1.1.1

Comments

@carlosefonseca
Copy link

I was trying to remove the zebra from the tables but using tableOddRowBackgroundColor(Color.WHITE) cleared half the borders of the table. I then switched to Color.RED and got the screenshot below
@carlosefonseca
Copy link
Author

carlosefonseca commented Aug 6, 2018 •
edited
Loading

After taking a look at the code, adding tableBorderColor(…) to the SpannableTheme fixes it.
The odd row sets the paint color and the border uses it because there's nothing set on the theme. Seems like a bug on the SpannableTheme since, by default, the table displays with a border color and it should be set on the theme.

@noties noties added the bug label Aug 6, 2018
@noties
Copy link
Owner

noties commented Aug 6, 2018

@carlosefonseca you are on 🔥 today! :)

@noties noties added this to the 1.1.1 milestone Aug 6, 2018
@noties
Copy link
Owner

noties commented Aug 14, 2018

Hello @carlosefonseca !

I did snapshot version with the fix. I also added customizations for even and headers rows

@noties noties mentioned this issue Aug 18, 2018
Merged
noties added a commit that referenced this issue Aug 18, 2018
@noties
V1.1.1 (#60)
20159be 
* Fix OrderedListItemSpan text position (baseline) (#55)
* Add softBreakAddsNewLine option for SpannableConfiguration (#54)
* Paragraph text can now explicitly be spanned (#58) 
  Thanks to @c-b-h!
* Fix table border color if odd background is specified (#56)
* Add table customizations (even and header rows)
@noties noties closed this as completed Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@carlosefonseca @noties