Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll backend: Release the lock while we sleep. #159

Merged
merged 1 commit into from Aug 5, 2018

Conversation

@Freaky
Copy link
Contributor

@Freaky Freaky commented Aug 5, 2018

If we sleep while holding the lock, we can block calls to watch().

Seeing this on FreeBSD, where even the most trivial example program will randomly hang while setting up watches.

If we sleep while holding the lock, we can block calls to watch().
@Keats
Copy link

@Keats Keats commented Aug 5, 2018

Looks like the OSX errors are legit?

@Freaky
Copy link
Contributor Author

@Freaky Freaky commented Aug 5, 2018

They don't look related to this commit, same failures are seen in the last master CI run.

@passcod
Copy link
Member

@passcod passcod commented Aug 5, 2018

Thanks for this, looks good.

@passcod passcod merged commit 3438155 into notify-rs:master Aug 5, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants