Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not stat a path if not recursive. #256

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Do not stat a path if not recursive. #256

merged 2 commits into from
Jul 16, 2020

Conversation

stuhood
Copy link
Contributor

@stuhood stuhood commented Jul 14, 2020 •
edited
Loading

Changing the order of the checks in EventLoop::add_watch avoids a stat for non-recursive watches.

@stuhood stuhood mentioned this pull request Jul 14, 2020
Open
JohnTitor
JohnTitor approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor merged commit 05da071 into notify-rs:main Jul 16, 2020
@stuhood stuhood deleted the stuhood/dont-stat-for-non-recursive branch July 16, 2020 16:19
This was referenced Oct 31, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchmindtree mitchmindtree mitchmindtree approved these changes

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stuhood @mitchmindtree @JohnTitor