Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minimum walkdir version to 2.2.2 #432

merged 1 commit into from Aug 15, 2022


Copy link

While trying out notify 5.0.0-pre.16, I got some issues as it declare a dependency on walkdir 2.0.1, but uses a function added in 2.2.2. This patch aims to fix that little issue.

I've tested the RC for my (arguably simple) use case, and on Linux it seems to work fine. I'll test on MacOS and Windows in the following days, and report if I got any issue.

Copy link
Contributor Author

trinity-1686a commented Aug 15, 2022

CI seems to have failed due to "1 cancelled checks" for macos-latest nightly. I'm not sure what that means or whether I can do something about it.

Edit: someone seems to have restarted the job. Thanks!

Copy link

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@JohnTitor JohnTitor merged commit 94f1680 into notify-rs:main Aug 15, 2022
12 checks passed
@trinity-1686a trinity-1686a deleted the update-min-walkdir branch August 15, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants